From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753866AbdKXVSV (ORCPT ); Fri, 24 Nov 2017 16:18:21 -0500 Received: from mx1.redhat.com ([209.132.183.28]:60376 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753766AbdKXVST (ORCPT ); Fri, 24 Nov 2017 16:18:19 -0500 Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20171124203750.GA559@zzz.localdomain> References: <20171124203750.GA559@zzz.localdomain> <20171120225757.96498-1-ebiggers3@gmail.com> <23022.1511538725@warthog.procyon.org.uk> To: Eric Biggers Cc: dhowells@redhat.com, keyrings@vger.kernel.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org, Eric Biggers Subject: Re: [PATCH] KEYS: remove unnecessary get/put of explicit dest_keyring MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <5477.1511558296.1@warthog.procyon.org.uk> Date: Fri, 24 Nov 2017 21:18:16 +0000 Message-ID: <5478.1511558296@warthog.procyon.org.uk> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Fri, 24 Nov 2017 21:18:19 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Eric Biggers wrote: > > > - construct_get_dest_keyring(&dest_keyring); > > > > This will break. construct_get_dest_keyring() does other things than just > > getting a ref on whatever dest_keyring points to. > > > > Not if dest_keyring is non-NULL (i.e. explicitly specified), which it is in > this case. Actually, you're right. David