Re: [PATCH] i8k: Add support for temperature sensor labels

Steven Honeyman
2014-11-29T16:37:36Z

On 29 November 2014 at 16:09, Pali Rohár <pali.rohar@gmail.com> wrote:
> On Saturday 29 November 2014 17:04:07 Pali Rohár wrote:
>> This patch adds labels for temperature sensors if SMM function
>> with EAX register 0x11a3 reports it. These informations was
>> taken from DOS binary NBSVC.MDM.
>>
>> Signed-off-by: Pali Rohár <pali.rohar@gmail.com>
>> ---
>> drivers/char/i8k.c | 110
>> +++++++++++++++++++++++++++++++++++++++++----------- 1 file
>> changed, 88 insertions(+), 22 deletions(-)
>
> I tested patch on Latitude E6440 and i8k CPU & GPU temps match
> intel coretemp & amd radeion temps.
>
> But I would like if somebody with other Dell laptop can test if
> temperature labels are correct...

Tested and working on E6540:
(I manually masked the serial/service tag)

-----Before-----

*[steven@e6540 linux]$ cat /proc/i8k
1.0 A12 6xxxxxx 44 -22 1 -22 3223 -1 -22
*[steven@e6540 linux]$ sensors
i8k-virtual-0
Adapter: Virtual device
fan2: 3223 RPM
temp1: +46.0°C
temp2: +44.0°C
temp3: +38.0°C

coretemp-isa-0000
Adapter: ISA adapter
Physical id 0: +49.0°C (high = +84.0°C, crit = +100.0°C)
Core 0: +45.0°C (high = +84.0°C, crit = +100.0°C)
Core 1: +49.0°C (high = +84.0°C, crit = +100.0°C)

-----After-----

*[steven@e6540 ~]$ cat /proc/i8k
1.0 A12 6xxxxxx 47 -22 1 -22 3176 -1 -22
*[steven@e6540 ~]$ sensors
i8k-virtual-0
Adapter: Virtual device
fan2: 3176 RPM
CPU: +47.0°C
Ambient: +45.0°C
SODIMM: +38.0°C

coretemp-isa-0000
Adapter: ISA adapter
Physical id 0: +47.0°C (high = +84.0°C, crit = +100.0°C)
Core 0: +45.0°C (high = +84.0°C, crit = +100.0°C)
Core 1: +46.0°C (high = +84.0°C, crit = +100.0°C)