Re: [PATCH] i8k: Add support for temperature sensor labels

Pali Rohár
2014-11-29T17:18:22Z

[-- Attachment #1: Type: Text/Plain, Size: 2520 bytes --]

On Saturday 29 November 2014 18:07:19 Gabriele Mazzotta wrote:
> On Saturday 29 November 2014 17:09:35 Pali Rohár wrote:
> > On Saturday 29 November 2014 17:04:07 Pali Rohár wrote:
> > > This patch adds labels for temperature sensors if SMM
> > > function with EAX register 0x11a3 reports it. These
> > > informations was taken from DOS binary NBSVC.MDM.
> > >
> > > Signed-off-by: Pali Rohár <pali.rohar@gmail.com>
> > > ---
> > >
> > > drivers/char/i8k.c | 110
> > >
> > > +++++++++++++++++++++++++++++++++++++++++----------- 1
> > > file changed, 88 insertions(+), 22 deletions(-)
> >
> > I tested patch on Latitude E6440 and i8k CPU & GPU temps
> > match intel coretemp & amd radeion temps.
> >
> > But I would like if somebody with other Dell laptop can test
> > if temperature labels are correct...
>
> I tested it on my XPS13 9333, here what sensors outputs:
>
> acpitz-virtual-0
> Adapter: Virtual device
> temp1: +27.8°C (crit = +105.0°C)
> temp2: +29.8°C (crit = +105.0°C)
>
> coretemp-isa-0000
> Adapter: ISA adapter
> Physical id 0: +62.0°C (high = +100.0°C, crit = +100.0°C)
> Core 0: +62.0°C (high = +100.0°C, crit = +100.0°C)
> Core 1: +61.0°C (high = +100.0°C, crit = +100.0°C)
>
> i8k-virtual-0
> Adapter: Virtual device
> fan2: 0 RPM
> CPU: +62.0°C
> Ambient: +49.0°C
> SODIMM: +46.0°C
> temp4: N/A
>
> CPU seems to be correct, but I can't say anything on Ambient
> and SODIMM. temp4 is constantly equal to SODIMM without this
> patch, so I'd say N/A is correct.
>
>
> Gabriele

It is unknown for me how to directly read Ambient and SODIMM
temperatures (without Dell SMM functions). So we can only trust
Dell SMM that it reporting correct values and type is really
Ambient and SODIMM.

And about temp4:

Label is not set when SMM function fails. Original DOS NBSVC.MDM
just ignore all sensors for which SMM type function fails.

This patch should not disable any sensor, so if you previously
had some value (<= 128°C) and now not, then there is some bug.

Can you test this patch?
https://git.kernel.org/cgit/linux/kernel/git/gregkh/char-misc.git/commit/?h=char-misc-testing&id=723493ca59c8d81fed3e7f261165fee493a29ffa

It is possible that same value is caused by incorrect use of
prev[] array which should be fixed by above patch.

Can you test i8k with and without above patch?

--
Pali Rohár
pali.rohar@gmail.com

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]