* [PATCH] skge: Unmask interrupts in case of spurious interrupts
@ 2014-11-30 11:51 Lino Sanfilippo
2014-12-01 9:53 ` Mirko Lindner
2014-12-06 5:34 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Lino Sanfilippo @ 2014-11-30 11:51 UTC (permalink / raw)
To: stephen; +Cc: mlindner, netdev, linux-kernel, Lino Sanfilippo
In case of a spurious interrupt dont forget to reenable the interrupts that
have been masked by reading the interrupt source register.
Signed-off-by: Lino Sanfilippo <LinoSanfilippo@gmx.de>
---
drivers/net/ethernet/marvell/skge.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/marvell/skge.c b/drivers/net/ethernet/marvell/skge.c
index 264eab7..7173836 100644
--- a/drivers/net/ethernet/marvell/skge.c
+++ b/drivers/net/ethernet/marvell/skge.c
@@ -3433,10 +3433,9 @@ static irqreturn_t skge_intr(int irq, void *dev_id)
if (status & IS_HW_ERR)
skge_error_irq(hw);
-
+out:
skge_write32(hw, B0_IMSK, hw->intr_mask);
skge_read32(hw, B0_IMSK);
-out:
spin_unlock(&hw->hw_lock);
return IRQ_RETVAL(handled);
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] skge: Unmask interrupts in case of spurious interrupts
2014-11-30 11:51 [PATCH] skge: Unmask interrupts in case of spurious interrupts Lino Sanfilippo
@ 2014-12-01 9:53 ` Mirko Lindner
2014-12-06 5:34 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Mirko Lindner @ 2014-12-01 9:53 UTC (permalink / raw)
To: Lino Sanfilippo; +Cc: stephen, netdev, linux-kernel
On 30/11/14 12:51, Lino Sanfilippo wrote:
> In case of a spurious interrupt dont forget to reenable the interrupts that
> have been masked by reading the interrupt source register.
>
> Signed-off-by: Lino Sanfilippo <LinoSanfilippo@gmx.de>
> ---
> drivers/net/ethernet/marvell/skge.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/marvell/skge.c b/drivers/net/ethernet/marvell/skge.c
> index 264eab7..7173836 100644
> --- a/drivers/net/ethernet/marvell/skge.c
> +++ b/drivers/net/ethernet/marvell/skge.c
> @@ -3433,10 +3433,9 @@ static irqreturn_t skge_intr(int irq, void *dev_id)
>
> if (status & IS_HW_ERR)
> skge_error_irq(hw);
> -
> +out:
> skge_write32(hw, B0_IMSK, hw->intr_mask);
> skge_read32(hw, B0_IMSK);
> -out:
> spin_unlock(&hw->hw_lock);
>
> return IRQ_RETVAL(handled);
>
Looks OK.
Acked-by: Mirko Lindner <mlindner@marvell.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] skge: Unmask interrupts in case of spurious interrupts
2014-11-30 11:51 [PATCH] skge: Unmask interrupts in case of spurious interrupts Lino Sanfilippo
2014-12-01 9:53 ` Mirko Lindner
@ 2014-12-06 5:34 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2014-12-06 5:34 UTC (permalink / raw)
To: LinoSanfilippo; +Cc: stephen, mlindner, netdev, linux-kernel
From: Lino Sanfilippo <LinoSanfilippo@gmx.de>
Date: Sun, 30 Nov 2014 12:51:31 +0100
> In case of a spurious interrupt dont forget to reenable the interrupts that
> have been masked by reading the interrupt source register.
>
> Signed-off-by: Lino Sanfilippo <LinoSanfilippo@gmx.de>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-12-06 5:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-11-30 11:51 [PATCH] skge: Unmask interrupts in case of spurious interrupts Lino Sanfilippo
2014-12-01 9:53 ` Mirko Lindner
2014-12-06 5:34 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox