Re: [PATCH 0/5] kvm: memslots lookup optimization

Paolo Bonzini
2014-12-02T13:24:21Z

On 02/12/2014 08:57, Igor Mammedov wrote:
>> On 01/12/2014 18:29, Igor Mammedov wrote:
>>> Series speed-ups GFN to memslot lookup time by:
>>> * introducing LRU cache, which improves looukup time for
>>> same slot workload (typically boot time of Windows and Linux guest)
>>> * switching to binary search for GFN to memslot lookup,
>>> improving lookup time with large amount of memory slots
>>>
>>> Igor Mammedov (5):
>>> kvm: update_memslots: drop not needed check for the same number of
>>> pages
>>> kvm: update_memslots: drop not needed check for the same slot
>>> kvm: search_memslots: add simple LRU memslot caching
>>> kvm: change memslot sorting rule from size to GFN
>>> kvm: optimize GFN to memslot lookup with large slots amount
>>>
>>> include/linux/kvm_host.h | 28 +++++++++++++++++++++++-----
>>> virt/kvm/kvm_main.c | 46 ++++++++++++++++++++++++++--------------------
>>> 2 files changed, 49 insertions(+), 25 deletions(-)
>>>
>>
>> Applied patches 1-3 for now, I'm not in the mood for proving that the
>> binary search is correct. :)

Looks good, thanks. Gleb, any objections?

Paolo