From: Christopher Covington <cov@codeaurora.org>
To: Jilai Wang <jilaiw@codeaurora.org>
Cc: dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org, robdclark@gmail.com
Subject: Re: [PATCH 2/4] drm/msm/hdmi: enable regulators before clocks to avoid warnings
Date: Mon, 01 Dec 2014 14:08:54 -0500 [thread overview]
Message-ID: <547CBCC6.3060805@codeaurora.org> (raw)
In-Reply-To: <1417032984-11869-1-git-send-email-jilaiw@codeaurora.org>
Hi Jilai,
On 11/26/2014 03:16 PM, Jilai Wang wrote:
> HPD regulators need to be enabled before clocks, otherwise clock
> driver will report warning.
>
> Change-Id: Ieca41722ae3b15873e6290649a21bbd13e1a4278
Nit: The upstream preference is to omit Change-Id lines. You should be able to
move .git/hooks/commit-msg to an alternate location and amend the patch to
remove it. Upstream checkpatch should warn about this--let me know if it's not
working properly.
Regards,
Chris
--
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2014-12-01 19:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-26 20:16 [PATCH 2/4] drm/msm/hdmi: enable regulators before clocks to avoid warnings Jilai Wang
2014-12-01 19:08 ` Christopher Covington [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-12-01 20:10 Jilai Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=547CBCC6.3060805@codeaurora.org \
--to=cov@codeaurora.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jilaiw@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robdclark@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox