From: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
To: Wang Nan <wangnan0@huawei.com>
Cc: tixy@linaro.org, linux@arm.linux.org.uk, lizefan@huawei.com,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v11 1/7] ARM: probes: move all probe code to dedicate directory
Date: Tue, 02 Dec 2014 13:59:07 +0900 [thread overview]
Message-ID: <547D471B.2070908@hitachi.com> (raw)
In-Reply-To: <1417423695-47521-1-git-send-email-wangnan0@huawei.com>
(2014/12/01 17:48), Wang Nan wrote:
> In discussion on LKML (https://lkml.org/lkml/2014/11/28/158), Russell
> King suggest to move all probe related code to arch/arm/probes. This
> patch do the work. Due to dependency on 'arch/arm/kernel/patch.h', this
> patch also move patch.h to 'arch/arm/include/asm/patch.h', and related
> '#include' directive are also midified to '#include <asm/patch.h>'.
Moving is good to me, but renaming files are also required I think.
> Signed-off-by: Wang Nan <wangnan0@huawei.com>
> ---
> arch/arm/Makefile | 1 +
> arch/arm/{kernel => include/asm}/patch.h | 0
> arch/arm/kernel/Makefile | 16 ++--------------
> arch/arm/kernel/jump_label.c | 2 +-
> arch/arm/kernel/patch.c | 3 +--
> arch/arm/probes/Makefile | 15 +++++++++++++++
> arch/arm/{kernel => probes}/kprobes-arm.c | 0
> arch/arm/{kernel => probes}/kprobes-common.c | 0
> arch/arm/{kernel => probes}/kprobes-test-arm.c | 0
> arch/arm/{kernel => probes}/kprobes-test-thumb.c | 0
> arch/arm/{kernel => probes}/kprobes-test.c | 0
> arch/arm/{kernel => probes}/kprobes-test.h | 0
> arch/arm/{kernel => probes}/kprobes-thumb.c | 0
> arch/arm/{kernel => probes}/kprobes.c | 2 +-
> arch/arm/{kernel => probes}/kprobes.h | 0
> arch/arm/{kernel => probes}/probes-arm.c | 0
> arch/arm/{kernel => probes}/probes-arm.h | 0
> arch/arm/{kernel => probes}/probes-thumb.c | 0
> arch/arm/{kernel => probes}/probes-thumb.h | 0
> arch/arm/{kernel => probes}/probes.c | 0
> arch/arm/{kernel => probes}/probes.h | 0
> arch/arm/{kernel => probes}/uprobes-arm.c | 0
> arch/arm/{kernel => probes}/uprobes.c | 0
> arch/arm/{kernel => probes}/uprobes.h | 0
As I did on x86, these would be better renamed as expressing what they do.
I guess most of the files may have emulate-*.c or decode-*.c :)
Thank you,
--
Masami HIRAMATSU
Software Platform Research Dept. Linux Technology Research Center
Hitachi, Ltd., Yokohama Research Laboratory
E-mail: masami.hiramatsu.pt@hitachi.com
next prev parent reply other threads:[~2014-12-02 4:59 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-01 8:45 [PATCH v11 0/7] ARM: kprobes: OPTPROBES and other improvements Wang Nan
2014-12-01 8:48 ` [PATCH v11 1/7] ARM: probes: move all probe code to dedicate directory Wang Nan
2014-12-02 4:59 ` Masami Hiramatsu [this message]
2014-12-02 10:16 ` [PATCH] " Wang Nan
2014-12-02 10:23 ` [PATCH v11 1/7] " Wang Nan
2014-12-03 4:38 ` Masami Hiramatsu
2014-12-03 5:28 ` Wang Nan
2014-12-03 6:27 ` Masami Hiramatsu
2014-12-01 8:48 ` [PATCH v11 2/7] ARM: kprobes: introduces checker Wang Nan
2014-12-01 8:48 ` [PATCH v11 3/7] ARM: kprobes: collects stack consumption for store instructions Wang Nan
2014-12-01 8:48 ` [PATCH v11 4/7] ARM: kprobes: disallow probing stack consuming instructions Wang Nan
2014-12-01 8:48 ` [PATCH v11 5/7] ARM: kprobes: Add test cases for " Wang Nan
2014-12-01 8:49 ` [PATCH v11 6/7] kprobes: Pass the original kprobe for preparing optimized kprobe Wang Nan
2014-12-01 8:49 ` [PATCH v11 7/7] ARM: kprobes: enable OPTPROBES for ARM 32 Wang Nan
2014-12-02 18:38 ` Jon Medhurst (Tixy)
2014-12-03 3:22 ` Wang Nan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=547D471B.2070908@hitachi.com \
--to=masami.hiramatsu.pt@hitachi.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=lizefan@huawei.com \
--cc=tixy@linaro.org \
--cc=wangnan0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox