From: Michal Marek <mmarek@suse.cz>
To: Nicholas Mc Guire <der.herr@hofr.at>
Cc: Randy Dunlap <rdunlap@infradead.org>,
Christoph Hellwig <hch@infradead.org>,
Joe Perches <joe@perches.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 4/5] limit _shipped to c h and S files
Date: Tue, 02 Dec 2014 12:49:22 +0100 [thread overview]
Message-ID: <547DA742.1010806@suse.cz> (raw)
In-Reply-To: <20141202103231.GA30141@opentech.at>
On 2014-12-02 11:32, Nicholas Mc Guire wrote:
> On Tue, 02 Dec 2014, Michal Marek wrote:
>
>> Dne 2.12.2014 v 10:16 Nicholas Mc Guire napsal(a):
>>>
>>> limit _shipped to c h and S files
>>>
>>> _shipped targets are intended for generated source files which should
>>> not permit .o binary blobs which is currently the case. This patch
>>> simply restricts _shipped targets to .c, .h and .S files.
>>
>>
>> IMO this just adds lines of code without any obvious advantage. The
>> other patches in the series are fine.
>>
>
> The idea simply was to make the behavior of kbuild match the
> documented intent of _shipped files.
The usage of *.o_shipped is documented by Documentation/kbuild/modules.txt.
Michal
next prev parent reply other threads:[~2014-12-02 11:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-02 9:16 [PATCH 4/5] limit _shipped to c h and S files Nicholas Mc Guire
2014-12-02 10:19 ` Michal Marek
2014-12-02 10:32 ` Nicholas Mc Guire
2014-12-02 11:49 ` Michal Marek [this message]
2014-12-02 13:27 ` Nicholas Mc Guire
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=547DA742.1010806@suse.cz \
--to=mmarek@suse.cz \
--cc=der.herr@hofr.at \
--cc=hch@infradead.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox