From: Shuah Khan <shuahkh@osg.samsung.com>
To: Christopher Covington <cov@codeaurora.org>,
Michael Ellerman <mpe@ellerman.id.au>
Cc: linux-kernel@vger.kernel.org, Andrew Morton <akpm@osdl.org>,
gorcunov@openvz.org, Arnd Bergmann <arnd@arndb.de>,
Shuah Khan <shuahkh@osg.samsung.com>
Subject: Re: [PATCH 3/3] selftests/kcmp: Always try to build the test
Date: Tue, 02 Dec 2014 13:59:45 -0700 [thread overview]
Message-ID: <547E2841.5090704@osg.samsung.com> (raw)
In-Reply-To: <547DE6D8.8090209@codeaurora.org>
On 12/02/2014 09:20 AM, Christopher Covington wrote:
> Hi Michael,
>
> On 12/02/2014 12:52 AM, Michael Ellerman wrote:
>> Don't prevent the test building on non-x86. Just try and build it and
>> let the chips fall where they may.
>>
>> Add support for CROSS_COMPILE while we're at it. Also we don't need a
>> custom rule for building kcmp_test.
>>
>> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
>
> For what it's worth, all three patches look good to me.
>
> Reviewed-by: Christopher Covington <cov@codeaurora.org>
>
> Thanks,
> Chris
>
All three patches queued for 3.19 - linux-kselftest.git/ fixes branch
kcmp fails on couple tests it runs when CONFIG_CHECKPOINT_RESTORE
is disabled. However, it isn't bad enough to not include the patch,
especially when there is use for it on arm.
FAIL: 0 expected but -1 returned (Function not implemented)
FAIL: 0 expected but -1 returned (Function not implemented)
-- Shuah
--
Shuah Khan
Sr. Linux Kernel Developer
Samsung Research America (Silicon Valley)
shuahkh@osg.samsung.com | (970) 217-8978
next prev parent reply other threads:[~2014-12-02 20:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-02 5:52 [PATCH 1/3] kcmp: Move kcmp.h into uapi Michael Ellerman
2014-12-02 5:52 ` [PATCH 2/3] selftests/kcmp: Don't include kernel headers Michael Ellerman
2014-12-02 5:52 ` [PATCH 3/3] selftests/kcmp: Always try to build the test Michael Ellerman
2014-12-02 16:20 ` Christopher Covington
2014-12-02 20:59 ` Shuah Khan [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-10-23 5:07 [PATCH 1/3] kcmp: Move kcmp.h into uapi Michael Ellerman
2014-10-23 5:07 ` [PATCH 3/3] selftests/kcmp: Always try to build the test Michael Ellerman
2014-10-23 6:09 ` Cyrill Gorcunov
2014-12-02 5:53 ` Michael Ellerman
2014-10-23 13:06 ` Christopher Covington
2014-10-23 13:52 ` Shuah Khan
2014-12-01 16:58 ` Shuah Khan
2014-12-02 5:44 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=547E2841.5090704@osg.samsung.com \
--to=shuahkh@osg.samsung.com \
--cc=akpm@osdl.org \
--cc=arnd@arndb.de \
--cc=cov@codeaurora.org \
--cc=gorcunov@openvz.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mpe@ellerman.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox