From: Daniel Borkmann <dborkman@redhat.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Julia Lawall <Julia.Lawall@lip6.fr>,
herbert@gondor.apana.org.au, kernel-janitors@vger.kernel.org,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
Julia Lawall <julia@diku.dk>
Subject: Re: [PATCH 8/8] wusb: replace memset by memzero_explicit
Date: Wed, 03 Dec 2014 01:18:41 +0100 [thread overview]
Message-ID: <547E56E1.2080105@redhat.com> (raw)
In-Reply-To: <20141203001408.GB21569@kroah.com>
On 12/03/2014 01:14 AM, Greg Kroah-Hartman wrote:
> On Sun, Nov 30, 2014 at 05:59:34PM +0100, Julia Lawall wrote:
>> From: Julia Lawall <julia@diku.dk>
>>
>> Memset on a local variable may be removed when it is called just before the
>> variable goes out of scope. Using memzero_explicit defeats this
>> optimization. A simplified version of the semantic patch that makes this
>> change is as follows: (http://coccinelle.lip6.fr/)
>>
>> // <smpl>
>> @@
>> identifier x;
>> type T;
>> @@
>>
>> {
>> ... when any
>> T x[...];
>> ... when any
>> when exists
>> - memset
>> + memzero_explicit
>> (x,
>> -0,
>> ...)
>> ... when != x
>> when strict
>> }
>> // </smpl>
>>
>> This change was suggested by Daniel Borkmann <dborkman@redhat.com>
>>
>> Signed-off-by: Julia Lawall <julia@diku.dk>
>>
>> ---
>> Daniel Borkmann suggested that these patches could go through Herbert Xu's
>> cryptodev tree.
>
> Why? There's no dependancy on anything in the cryptodev tree,
> memzero_explicit is in Linus's tree now.
Sorry, I guess this was not really clear, that comment actually only
refers to the arch/*/crypto/ patches.
Anyway, thanks for queueing this up, Greg.
Cheers,
Daniel
prev parent reply other threads:[~2014-12-03 0:19 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-30 16:59 [PATCH 0/8] replace memset by memzero_explicit Julia Lawall
2014-11-30 16:59 ` [PATCH 1/8] purgatory/sha256: " Julia Lawall
2014-12-01 15:20 ` David Sterba
2014-11-30 16:59 ` [PATCH 2/8] sparc64: " Julia Lawall
2014-11-30 16:59 ` [PATCH 3/8] crypto: " Julia Lawall
2014-11-30 16:59 ` [PATCH 4/8] cifs: " Julia Lawall
2014-11-30 16:59 ` [PATCH 5/8] dm: " Julia Lawall
2014-11-30 16:59 ` [PATCH 6/8] crypto: " Julia Lawall
2014-11-30 16:59 ` [PATCH 7/8] " Julia Lawall
2014-11-30 16:59 ` [PATCH 8/8] wusb: " Julia Lawall
2014-12-03 0:14 ` Greg Kroah-Hartman
2014-12-03 0:18 ` Daniel Borkmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=547E56E1.2080105@redhat.com \
--to=dborkman@redhat.com \
--cc=Julia.Lawall@lip6.fr \
--cc=gregkh@linuxfoundation.org \
--cc=herbert@gondor.apana.org.au \
--cc=julia@diku.dk \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox