From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752595AbaLDCWb (ORCPT ); Wed, 3 Dec 2014 21:22:31 -0500 Received: from aserp1040.oracle.com ([141.146.126.69]:41521 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752487AbaLDCW3 (ORCPT ); Wed, 3 Dec 2014 21:22:29 -0500 Message-ID: <547FC556.8010301@oracle.com> Date: Thu, 04 Dec 2014 10:22:14 +0800 From: ethan zhao Organization: Oracle Corporation User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20130107 Thunderbird/17.0.2 MIME-Version: 1.0 To: Ethan Zhao CC: dirk.j.brandewie@intel.com, linda.knippers@hp.com, viresh.kumar@linaro.org, rjw@rjwysocki.net, corbet@lwn.net, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, ethan.kernel@gmail.com, Alexey Kodanev Subject: Re: [PATCH 2/2 V7] intel_pstate: add kernel parameter to force loading on Sun X86 servers. References: <1417658851-8729-1-git-send-email-ethan.zhao@oracle.com> In-Reply-To: <1417658851-8729-1-git-send-email-ethan.zhao@oracle.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Source-IP: acsinet21.oracle.com [141.146.126.237] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Alexey has tested this patch on Lenovo machines. so Tested-by: Alexey Kodanev On 2014/12/4 10:07, Ethan Zhao wrote: > To force loading on Oracle Sun X86 servers, provide one kernel command line > parameter > > intel_pstate = ora_force > > For those who be aware of the risk of no power capping capabily working and > try to get better performance with this driver. > > Signed-off-by: Ethan Zhao > --- > v2: change to hardware vendor specific naming parameter. > v4: refine code and doc. > v5&v6: fix a typo in doc. > v7: change enum PCC to PPC. > > Documentation/kernel-parameters.txt | 5 +++++ > drivers/cpufreq/intel_pstate.c | 6 +++++- > 2 files changed, 10 insertions(+), 1 deletion(-) > > diff --git a/Documentation/kernel-parameters.txt b/Documentation/kernel-parameters.txt > index 479f332..7d0983e 100644 > --- a/Documentation/kernel-parameters.txt > +++ b/Documentation/kernel-parameters.txt > @@ -1446,6 +1446,11 @@ bytes respectively. Such letter suffixes can also be entirely omitted. > disable > Do not enable intel_pstate as the default > scaling driver for the supported processors > + ora_force > + Force loading intel_pstate on Oracle Sun Servers(X86). > + only for those who be aware of the risk of no power capping > + capability working and try to get better performance with this > + driver. > > intremap= [X86-64, Intel-IOMMU] > on enable Interrupt Remapping (default) > diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_pstate.c > index 1bb62ca..2654e13 100644 > --- a/drivers/cpufreq/intel_pstate.c > +++ b/drivers/cpufreq/intel_pstate.c > @@ -866,6 +866,7 @@ static struct cpufreq_driver intel_pstate_driver = { > }; > > static int __initdata no_load; > +static unsigned int ora_force; > > static int intel_pstate_msrs_not_valid(void) > { > @@ -1003,7 +1004,8 @@ static bool intel_pstate_platform_pwr_mgmt_exists(void) > case PSS: > return intel_pstate_no_acpi_pss(); > case PPC: > - return intel_pstate_has_acpi_ppc(); > + return intel_pstate_has_acpi_ppc() && > + (!ora_force); > } > } > > @@ -1078,6 +1080,8 @@ static int __init intel_pstate_setup(char *str) > > if (!strcmp(str, "disable")) > no_load = 1; > + if (!strcmp(str, "ora_force")) > + ora_force = 1; > return 0; > } > early_param("intel_pstate", intel_pstate_setup);