* [PATCH] amdkfd: use sizeof(long) granularity for the pasid bitmask
@ 2014-12-03 14:26 Sasha Levin
2014-12-04 12:21 ` Oded Gabbay
0 siblings, 1 reply; 2+ messages in thread
From: Sasha Levin @ 2014-12-03 14:26 UTC (permalink / raw)
To: oded.gabbay
Cc: airlied, alexander.deucher, j.glisse, linux-kernel, dri-devel,
John.Bridgman, Andrew.Lewycky, joro, Sasha Levin
All the bit operations (such as find_first_zero_bit()) read sizeof(long) bytes
at a time. If we allocated less than sizeof(long) bytes for the bitmask we
would be accessing invalid memory when working with the bitmask.
Change the allocator to allocate sizeof(long) multiples for the bitmask.
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
---
drivers/gpu/drm/amd/amdkfd/kfd_pasid.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_pasid.c b/drivers/gpu/drm/amd/amdkfd/kfd_pasid.c
index 2458ab7..71699ad 100644
--- a/drivers/gpu/drm/amd/amdkfd/kfd_pasid.c
+++ b/drivers/gpu/drm/amd/amdkfd/kfd_pasid.c
@@ -32,8 +32,7 @@ int kfd_pasid_init(void)
{
pasid_limit = max_num_of_processes;
- pasid_bitmap = kzalloc(DIV_ROUND_UP(pasid_limit, BITS_PER_BYTE),
- GFP_KERNEL);
+ pasid_bitmap = kzalloc(BITS_TO_LONGS(pasid_limit), GFP_KERNEL);
if (!pasid_bitmap)
return -ENOMEM;
--
2.1.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] amdkfd: use sizeof(long) granularity for the pasid bitmask
2014-12-03 14:26 [PATCH] amdkfd: use sizeof(long) granularity for the pasid bitmask Sasha Levin
@ 2014-12-04 12:21 ` Oded Gabbay
0 siblings, 0 replies; 2+ messages in thread
From: Oded Gabbay @ 2014-12-04 12:21 UTC (permalink / raw)
To: Sasha Levin
Cc: airlied, alexander.deucher, j.glisse, linux-kernel, dri-devel,
John.Bridgman, Andrew.Lewycky, joro
On 12/03/2014 04:26 PM, Sasha Levin wrote:
> All the bit operations (such as find_first_zero_bit()) read sizeof(long) bytes
> at a time. If we allocated less than sizeof(long) bytes for the bitmask we
> would be accessing invalid memory when working with the bitmask.
>
> Change the allocator to allocate sizeof(long) multiples for the bitmask.
>
> Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
> ---
> drivers/gpu/drm/amd/amdkfd/kfd_pasid.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_pasid.c b/drivers/gpu/drm/amd/amdkfd/kfd_pasid.c
> index 2458ab7..71699ad 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_pasid.c
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_pasid.c
> @@ -32,8 +32,7 @@ int kfd_pasid_init(void)
> {
> pasid_limit = max_num_of_processes;
>
> - pasid_bitmap = kzalloc(DIV_ROUND_UP(pasid_limit, BITS_PER_BYTE),
> - GFP_KERNEL);
> + pasid_bitmap = kzalloc(BITS_TO_LONGS(pasid_limit), GFP_KERNEL);
> if (!pasid_bitmap)
> return -ENOMEM;
>
>
Thanks!
Applied to my -next tree.
Oded
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-12-04 12:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-12-03 14:26 [PATCH] amdkfd: use sizeof(long) granularity for the pasid bitmask Sasha Levin
2014-12-04 12:21 ` Oded Gabbay
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox