* [PATCH] amdkfd: use atomic allocations within srcu callbacks
@ 2014-12-03 15:19 Sasha Levin
2014-12-04 12:27 ` Oded Gabbay
0 siblings, 1 reply; 2+ messages in thread
From: Sasha Levin @ 2014-12-03 15:19 UTC (permalink / raw)
To: oded.gabbay
Cc: airlied, alexander.deucher, j.glisse, linux-kernel, dri-devel,
John.Bridgman, Andrew.Lewycky, joro, Sasha Levin
srcu callbacks are running in atomic context, we can't allocate using
__GFP_WAIT.
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
---
drivers/gpu/drm/amd/amdkfd/kfd_process.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_process.c b/drivers/gpu/drm/amd/amdkfd/kfd_process.c
index b4f49ac..b85eb0b 100644
--- a/drivers/gpu/drm/amd/amdkfd/kfd_process.c
+++ b/drivers/gpu/drm/amd/amdkfd/kfd_process.c
@@ -196,7 +196,7 @@ static void kfd_process_destroy_delayed(struct rcu_head *rcu)
mmdrop(p->mm);
work = (struct kfd_process_release_work *)
- kmalloc(sizeof(struct kfd_process_release_work), GFP_KERNEL);
+ kmalloc(sizeof(struct kfd_process_release_work), GFP_ATOMIC);
if (work) {
INIT_WORK((struct work_struct *) work, kfd_process_wq_release);
--
2.1.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] amdkfd: use atomic allocations within srcu callbacks
2014-12-03 15:19 [PATCH] amdkfd: use atomic allocations within srcu callbacks Sasha Levin
@ 2014-12-04 12:27 ` Oded Gabbay
0 siblings, 0 replies; 2+ messages in thread
From: Oded Gabbay @ 2014-12-04 12:27 UTC (permalink / raw)
To: Sasha Levin
Cc: airlied, alexander.deucher, j.glisse, linux-kernel, dri-devel,
John.Bridgman, Andrew.Lewycky, joro
On 12/03/2014 05:19 PM, Sasha Levin wrote:
> srcu callbacks are running in atomic context, we can't allocate using
> __GFP_WAIT.
>
> Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
> ---
> drivers/gpu/drm/amd/amdkfd/kfd_process.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_process.c b/drivers/gpu/drm/amd/amdkfd/kfd_process.c
> index b4f49ac..b85eb0b 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_process.c
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_process.c
> @@ -196,7 +196,7 @@ static void kfd_process_destroy_delayed(struct rcu_head *rcu)
> mmdrop(p->mm);
>
> work = (struct kfd_process_release_work *)
> - kmalloc(sizeof(struct kfd_process_release_work), GFP_KERNEL);
> + kmalloc(sizeof(struct kfd_process_release_work), GFP_ATOMIC);
>
> if (work) {
> INIT_WORK((struct work_struct *) work, kfd_process_wq_release);
>
Thanks!
Applied to my -next tree.
Oded
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-12-04 12:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-12-03 15:19 [PATCH] amdkfd: use atomic allocations within srcu callbacks Sasha Levin
2014-12-04 12:27 ` Oded Gabbay
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox