Re: [PATCH] scripts/package: binrpm-pkg do not create source and devel package v3

[Michal Marek <mmarek@suse.cz>]

On 2014-12-02 21:45, j.glisse@gmail.com wrote:
> From: Jérôme Glisse <jglisse@redhat.com>
> 
> When doing make binrpm-pkg we only want to build the binary and header
> package as the documentation of binrpm-pkg target claims. Hence this
> patch avoid building the source and devel package. This makes binrpm-pkg
> target lot faster and way more usefull.
> 
> Changed since v2 :
>   - Avoid symlinks in /usr/src/kernel.
>   - Update subject line and changelog.

Thanks, much better!


>  echo 'rm -f $RPM_BUILD_ROOT'"/lib/modules/$KERNELRELEASE/{build,source}"
>  echo "mkdir -p "'$RPM_BUILD_ROOT'"/usr/src/kernels/$KERNELRELEASE"

One last nitpick, then I'll merge the patch (promise!) -- the
/usr/src/kernels/$KERNELRELEASE directory is not needed and in fact the
rm -f above is also irrelevant. So please wrap the whole block in if !
$PREBUILT.

Thanks,
Michal