From: Mark Hounschell <markh@compro.net>
To: Joe Perches <joe@perches.com>, Sean Cleator <seancleator@hotmail.co.uk>
Cc: lidza.louina@gmail.com, gregkh@linuxfoundation.org,
driverdev-devel@linuxdriverproject.org,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] Staging: dgnc: Fix long line coding style issues in dgnc_cls.h
Date: Thu, 04 Dec 2014 12:47:43 -0500 [thread overview]
Message-ID: <54809E3F.7050605@compro.net> (raw)
In-Reply-To: <1723574984.368832.1417649865878.JavaMail.root@mx2.compro.net>
On 12/03/2014 06:37 PM, Joe Perches wrote:
> On Wed, 2014-12-03 at 21:30 +0000, Sean Cleator wrote:
>> A patch to fix the rest of the long line warnings in the dgnc_cls.h file
>> found by the checkpatch.pl tool
>
> checkpatch is a brainless little tool.
>
> You should prefer to develop a readable style rather than
> pay too close attention to precisely what checkpatch says.
>
> fyi: There is this warning in the file:
>
> * NOTE: THIS IS A SHARED HEADER. DO NOT CHANGE CODING STYLE!!!
>
That comment should be removed. It was put there when this driver was
under Digi's CVS control. Some of their user land apps, delivered with
the driver package, also used it. They probably had different people
working on the kernel and user land side.
Mark
prev parent reply other threads:[~2014-12-04 17:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-03 21:30 [PATCH v2] Staging: dgnc: Fix long line coding style issues in dgnc_cls.h Sean Cleator
2014-12-03 23:37 ` Joe Perches
[not found] ` <1723574984.368832.1417649865878.JavaMail.root@mx2.compro.net>
2014-12-04 17:47 ` Mark Hounschell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54809E3F.7050605@compro.net \
--to=markh@compro.net \
--cc=devel@driverdev.osuosl.org \
--cc=driverdev-devel@linuxdriverproject.org \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=lidza.louina@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=seancleator@hotmail.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox