From: Carlos Bilbao <bilbao@vt.edu>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Arnd Bergmann <arnd@arndb.de>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Geert Uytterhoeven <geert@linux-m68k.org>,
jianyong.wu@arm.com, Matthew Wilcox <willy@infradead.org>
Subject: Re: [PATCH v2] include: linux: Reorganize timekeeping and ktime headers
Date: Thu, 22 Jul 2021 07:54:22 -0400 [thread overview]
Message-ID: <5481133.DvuYhMxLoT@iron-maiden> (raw)
In-Reply-To: <87fsw7pe5d.ffs@nanos.tec.linutronix.de>
On Wednesday, July 21, 2021 5:09:50 PM EDT Thomas Gleixner wrote:
>
> I have no objections against this change per se, but I'm missing the
> actual problem it is trying to solve. What's the fail it fixes or is it
> just a general consolidation? The above is blury in that regard.
>
Well, at first I just wanted to fix the header dependencies, since timekeeping.h
is using ktime_to_ns(), a static function defined ktime.h, but it does not
include the header. Then Arnd rightly pointed out this was an opportunity to
perform a bit more housekeeping and consolidation, yes.
> > This patch also includes the header timekeeping.h wherever it is
> > necessary for a successful compilation after the header code
> > reorganization.
>
> Please do:
>
> git grep 'This patch' Documentation/process/
>
> and follow the instructions there.
All right, I understand I should be following the imperative mood there.
>
> Aside of that I assume that you only covered x86 in build testing which
> is not cutting it as this is generic infrastructure affecting _all_
> architectures.
>
> Thanks,
>
> tglx
Thanks for the feedback Thomas, I will cross compile with the other archs
to make sure we are not leaving anyone behind and send updated version (v3).
Carlos-
next prev parent reply other threads:[~2021-07-22 11:54 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <5729424.lOV4Wx5bFT@iron-maiden>
[not found] ` <2591466.mvXUDI8C0e@iron-maiden>
[not found] ` <5481808.DvuYhMxLoT@iron-maiden>
2021-07-15 16:12 ` [PATCH] include: linux: Reorganize timekeeping and ktime headers Carlos Bilbao
2021-07-15 18:57 ` Arnd Bergmann
2021-07-19 15:16 ` Carlos Bilbao
2021-07-19 15:19 ` [PATCH v2] " Carlos Bilbao
2021-07-21 21:09 ` Thomas Gleixner
2021-07-22 11:54 ` Carlos Bilbao [this message]
2021-07-22 15:31 ` [PATCH v3] " Carlos Bilbao
2021-07-22 18:19 ` kernel test robot
2021-07-22 18:41 ` kernel test robot
2021-07-22 19:19 ` kernel test robot
2021-07-31 16:29 ` [PATCH v4] " Carlos Bilbao
2022-02-08 16:10 [PATCH v2] " Carlos Bilbao
2022-02-08 21:48 ` kernel test robot
2022-02-08 23:10 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5481133.DvuYhMxLoT@iron-maiden \
--to=bilbao@vt.edu \
--cc=arnd@arndb.de \
--cc=geert@linux-m68k.org \
--cc=jianyong.wu@arm.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox