* [PATCH wq/for-3.19] workqueue: cosmetic update in rescuer_thread()
@ 2014-12-04 15:14 Tejun Heo
2014-12-05 2:10 ` Lai Jiangshan
0 siblings, 1 reply; 2+ messages in thread
From: Tejun Heo @ 2014-12-04 15:14 UTC (permalink / raw)
To: Lai Jiangshan; +Cc: linux-kernel
rescuer_thread() caches &rescuer->scheduled in a local variable
scheduled for convenience. There's one WARN_ON_ONCE() which was using
&rescuer->scheduled directly. Replace it with the local variable.
This patch causes no functional difference.
Signed-off-by: Tejun Heo <tj@kernel.org>
---
Applying to wq/for-3.19.
Thanks.
kernel/workqueue.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/kernel/workqueue.c
+++ b/kernel/workqueue.c
@@ -2246,7 +2246,7 @@ repeat:
* Slurp in all works issued via this workqueue and
* process'em.
*/
- WARN_ON_ONCE(!list_empty(&rescuer->scheduled));
+ WARN_ON_ONCE(!list_empty(scheduled));
list_for_each_entry_safe(work, n, &pool->worklist, entry)
if (get_work_pwq(work) == pwq)
move_linked_works(work, scheduled, &n);
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH wq/for-3.19] workqueue: cosmetic update in rescuer_thread()
2014-12-04 15:14 [PATCH wq/for-3.19] workqueue: cosmetic update in rescuer_thread() Tejun Heo
@ 2014-12-05 2:10 ` Lai Jiangshan
0 siblings, 0 replies; 2+ messages in thread
From: Lai Jiangshan @ 2014-12-05 2:10 UTC (permalink / raw)
To: Tejun Heo; +Cc: linux-kernel
On 12/04/2014 11:14 PM, Tejun Heo wrote:
> rescuer_thread() caches &rescuer->scheduled in a local variable
> scheduled for convenience. There's one WARN_ON_ONCE() which was using
> &rescuer->scheduled directly. Replace it with the local variable.
>
> This patch causes no functional difference.
>
> Signed-off-by: Tejun Heo <tj@kernel.org>
> ---
Reviewed-by: Lai Jiangshan <laijs@cn.fujitsu.com>
> Applying to wq/for-3.19.
>
> Thanks.
>
> kernel/workqueue.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- a/kernel/workqueue.c
> +++ b/kernel/workqueue.c
> @@ -2246,7 +2246,7 @@ repeat:
> * Slurp in all works issued via this workqueue and
> * process'em.
> */
> - WARN_ON_ONCE(!list_empty(&rescuer->scheduled));
> + WARN_ON_ONCE(!list_empty(scheduled));
> list_for_each_entry_safe(work, n, &pool->worklist, entry)
> if (get_work_pwq(work) == pwq)
> move_linked_works(work, scheduled, &n);
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-12-05 2:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-12-04 15:14 [PATCH wq/for-3.19] workqueue: cosmetic update in rescuer_thread() Tejun Heo
2014-12-05 2:10 ` Lai Jiangshan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox