From: David Vrabel <david.vrabel@citrix.com>
To: Juergen Gross <jgross@suse.com>, <linux-kernel@vger.kernel.org>,
<xen-devel@lists.xensource.com>, <konrad.wilk@oracle.com>,
<david.vrabel@citrix.com>, <boris.ostrovsky@oracle.com>
Subject: Re: [Xen-devel] [PATCH] xen: fix sparse warning in p2m.c
Date: Fri, 5 Dec 2014 10:43:12 +0000 [thread overview]
Message-ID: <54818C40.5020706@citrix.com> (raw)
In-Reply-To: <1417760195-16911-1-git-send-email-jgross@suse.com>
On 05/12/14 06:16, Juergen Gross wrote:
> The patch "Speed up set_phys_to_machine() by using read-only mappings"
> introduced a sparse warning:
>
> arch/x86/xen/p2m.c:628:13: sparse: incorrect type in argument 1
> (different address spaces)
>
> Avoid the warning.
Thanks.
But can you add some helper functions instead? Perhaps:
static inline int xen_safe_write_ulong(unsigned long *addr,
unsigned long val)
{
//...
}
static inline int xen_safe_read_ulong(unsigned long *addr,
unsigned long *val)
{
//...
}
David
prev parent reply other threads:[~2014-12-05 10:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-05 6:16 [PATCH] xen: fix sparse warning in p2m.c Juergen Gross
2014-12-05 10:43 ` David Vrabel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54818C40.5020706@citrix.com \
--to=david.vrabel@citrix.com \
--cc=boris.ostrovsky@oracle.com \
--cc=jgross@suse.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox