From: Jiri Slaby <jslaby@suse.cz>
To: Seth Jennings <sjenning@redhat.com>,
Josh Poimboeuf <jpoimboe@redhat.com>,
Jiri Kosina <jkosina@suse.cz>, Vojtech Pavlik <vojtech@suse.cz>,
Steven Rostedt <rostedt@goodmis.org>,
Petr Mladek <pmladek@suse.cz>, Miroslav Benes <mbenes@suse.cz>,
Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Cc: Christoph Hellwig <hch@infradead.org>,
Greg KH <gregkh@linuxfoundation.org>,
Andy Lutomirski <luto@amacapital.net>,
live-patching@vger.kernel.org, x86@kernel.org, kpatch@redhat.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCHv5 2/3] kernel: add support for live patching
Date: Fri, 05 Dec 2014 18:55:04 +0100 [thread overview]
Message-ID: <5481F178.9000306@suse.cz> (raw)
In-Reply-To: <1417708411-23655-3-git-send-email-sjenning@redhat.com>
On 12/04/2014, 04:53 PM, Seth Jennings wrote:
...
> --- /dev/null
> +++ b/kernel/livepatch/core.c
> @@ -0,0 +1,902 @@
...
> +static struct kobj_type klp_ktype_patch = {
> + .sysfs_ops = &kobj_sysfs_ops,
> + .default_attrs = klp_patch_attrs
> +};
Hi, I seem to have only a single comment here. If I am looking
correctly, the last put on this kobject will cause kobject_cleanup to
generate a warning:
"kobject: '%s' (%p): does not have a release() "
"function, it is broken and must be fixed.\n",
There should be some .release. IMO, this is a place where we will
release the module with the patch. So the .release hook should contain
something like a commented out module_put() with a pointer to
klp_register_patch. (Or be empty at worst.)
thanks,
--
js
suse labs
next prev parent reply other threads:[~2014-12-05 17:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-04 15:53 [PATCHv5 0/3] Kernel Live Patching Seth Jennings
2014-12-04 15:53 ` [PATCHv5 1/3] kernel: add TAINT_LIVEPATCH Seth Jennings
2014-12-04 15:53 ` [PATCHv5 2/3] kernel: add support for live patching Seth Jennings
2014-12-05 17:55 ` Jiri Slaby [this message]
2014-12-05 19:50 ` Josh Poimboeuf
2014-12-09 17:56 ` Petr Mladek
2014-12-04 15:53 ` [PATCHv5 3/3] samples: add sample live patching module Seth Jennings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5481F178.9000306@suse.cz \
--to=jslaby@suse.cz \
--cc=gregkh@linuxfoundation.org \
--cc=hch@infradead.org \
--cc=jkosina@suse.cz \
--cc=jpoimboe@redhat.com \
--cc=kpatch@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=live-patching@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=masami.hiramatsu.pt@hitachi.com \
--cc=mbenes@suse.cz \
--cc=pmladek@suse.cz \
--cc=rostedt@goodmis.org \
--cc=sjenning@redhat.com \
--cc=vojtech@suse.cz \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).