public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: David Daney <ddaney.cavm@gmail.com>
To: Christoph Lameter <cl@linux.com>
Cc: "Kees Cook" <keescook@chromium.org>,
	"Leonid Yegoshin" <Leonid.Yegoshin@imgtec.com>,
	"Linux MIPS Mailing List" <linux-mips@linux-mips.org>,
	Zubair.Kakakhel@imgtec.com, geert+renesas@glider.be,
	david.daney@cavium.com, "Peter Zijlstra" <peterz@infradead.org>,
	"Paul Gortmaker" <paul.gortmaker@windriver.com>,
	davidlohr@hp.com, "Maciej W. Rozycki" <macro@linux-mips.org>,
	chenhc@lemote.com, "Ingo Molnar" <mingo@kernel.org>,
	"Richard Weinberger" <richard@nod.at>,
	"Rafał Miłecki" <zajec5@gmail.com>,
	"James Hogan" <james.hogan@imgtec.com>,
	"Tejun Heo" <tj@kernel.org>,
	alex@alex-smith.me.uk, "Paolo Bonzini" <pbonzini@redhat.com>,
	"John Crispin" <blogic@openwrt.org>,
	"Paul Burton" <paul.burton@imgtec.com>,
	qais.yousef@imgtec.com, LKML <linux-kernel@vger.kernel.org>,
	"Ralf Baechle" <ralf@linux-mips.org>,
	"Markos Chandras" <markos.chandras@imgtec.com>,
	dengcheng.zhu@imgtec.com, manuel.lauss@gmail.com,
	lars.persson@axis.com
Subject: Re: [PATCH v3 3/3] MIPS: set stack/data protection as non-executable
Date: Fri, 05 Dec 2014 13:41:08 -0800	[thread overview]
Message-ID: <54822674.20907@gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.11.1412051343330.5206@gentwo.org>

On 12/05/2014 11:44 AM, Christoph Lameter wrote:
> On Fri, 5 Dec 2014, David Daney wrote:
>
>> The problem is not with "modern" executables that are properly annotated with
>> PT_GNU_STACK.
>>
>> My objection is to the intentional breaking of old executables that have no
>> PT_GNU_STACK annotation, but require an executable stack.  Since we usually
>> try not to break userspace, we cannot merge a patch like this one.
>
> How old are these and how many are still around?

As far as I can determine, no official GCC release defaults to 
generating PT_GNU_STACK for MIPS, I could be mistaken though.  So to 
answer your questions:  Very young, and all of them.


> Can the annotation be added with a tool?

I don't know, although I seem to recall that such a tool existed, and I 
may have even used it in the past.  But, my google fu is not 
sufficiently advanced to find it now, if it exists.

David Daney


      reply	other threads:[~2014-12-05 21:41 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-03  1:57 [PATCH v3 0/3] Series short description Leonid Yegoshin
2014-12-03  1:58 ` [PATCH v3 1/3] MIPS: mips_flush_cache_range is added Leonid Yegoshin
2014-12-03  1:58 ` [PATCH v3 2/3] MIPS: Setup an instruction emulation in VDSO protected page instead of user stack Leonid Yegoshin
2014-12-03  1:58 ` [PATCH v3 3/3] MIPS: set stack/data protection as non-executable Leonid Yegoshin
2014-12-05 17:28   ` David Daney
2014-12-05 18:51     ` Kees Cook
2014-12-05 19:06       ` David Daney
2014-12-05 19:41         ` Leonid Yegoshin
2014-12-05 19:41         ` Kees Cook
2014-12-05 19:44         ` Christoph Lameter
2014-12-05 21:41           ` David Daney [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54822674.20907@gmail.com \
    --to=ddaney.cavm@gmail.com \
    --cc=Leonid.Yegoshin@imgtec.com \
    --cc=Zubair.Kakakhel@imgtec.com \
    --cc=alex@alex-smith.me.uk \
    --cc=blogic@openwrt.org \
    --cc=chenhc@lemote.com \
    --cc=cl@linux.com \
    --cc=david.daney@cavium.com \
    --cc=davidlohr@hp.com \
    --cc=dengcheng.zhu@imgtec.com \
    --cc=geert+renesas@glider.be \
    --cc=james.hogan@imgtec.com \
    --cc=keescook@chromium.org \
    --cc=lars.persson@axis.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@linux-mips.org \
    --cc=macro@linux-mips.org \
    --cc=manuel.lauss@gmail.com \
    --cc=markos.chandras@imgtec.com \
    --cc=mingo@kernel.org \
    --cc=paul.burton@imgtec.com \
    --cc=paul.gortmaker@windriver.com \
    --cc=pbonzini@redhat.com \
    --cc=peterz@infradead.org \
    --cc=qais.yousef@imgtec.com \
    --cc=ralf@linux-mips.org \
    --cc=richard@nod.at \
    --cc=tj@kernel.org \
    --cc=zajec5@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox