public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Romain Baeriswyl <romain.baeriswyl@alitech.com>
To: Doug Anderson <dianders@chromium.org>,
	Romain Baeriswyl <Romain.Baeriswyl@abilis.com>,
	Wolfram Sang <wsa@the-dreams.de>,
	Shinya Kuribayashi <skuribay@pobox.com>
Cc: Christian Ruppert <christian.ruppert@abilis.com>,
	Addy Ke <addy.ke@rock-chips.com>,
	robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com,
	ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] i2c: designware: Fix falling time bindings doc
Date: Mon, 08 Dec 2014 09:57:07 +0100	[thread overview]
Message-ID: <548567E3.6020101@alitech.com> (raw)
In-Reply-To: <1417805379-8999-1-git-send-email-dianders@chromium.org>

Acked-by: Romain Baeriswyl <romain.baeriswyl@alitech.com>


On 2014-12-05 19:49, Doug Anderson wrote:
> In (6468276 i2c: designware: make SCL and SDA falling time
> configurable) new device tree properties were added for setting the
> falling time of SDA and SCL.  The device tree bindings doc had a typo
> in it: it forgot the "-ns" suffix for both properies in the prose of
> the bindings.
>
> I assume this is a typo because:
> * The source code includes the "-ns"
> * The example in the bindings includes the "-ns".
>
> Fix the typo.
>
> Signed-off-by: Doug Anderson <dianders@chromium.org>
> Fixes: 6468276b2206 ("i2c: designware: make SCL and SDA falling time configurable")
> ---
>   Documentation/devicetree/bindings/i2c/i2c-designware.txt | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/i2c/i2c-designware.txt b/Documentation/devicetree/bindings/i2c/i2c-designware.txt
> index 5199b0c..fee26dc 100644
> --- a/Documentation/devicetree/bindings/i2c/i2c-designware.txt
> +++ b/Documentation/devicetree/bindings/i2c/i2c-designware.txt
> @@ -14,10 +14,10 @@ Optional properties :
>    - i2c-sda-hold-time-ns : should contain the SDA hold time in nanoseconds.
>      This option is only supported in hardware blocks version 1.11a or newer.
>
> - - i2c-scl-falling-time : should contain the SCL falling time in nanoseconds.
> + - i2c-scl-falling-time-ns : should contain the SCL falling time in nanoseconds.
>      This value which is by default 300ns is used to compute the tLOW period.
>
> - - i2c-sda-falling-time : should contain the SDA falling time in nanoseconds.
> + - i2c-sda-falling-time-ns : should contain the SDA falling time in nanoseconds.
>      This value which is by default 300ns is used to compute the tHIGH period.
>
>   Example :
>


  reply	other threads:[~2014-12-08  9:29 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-05 18:49 [PATCH] i2c: designware: Fix falling time bindings doc Doug Anderson
2014-12-08  8:57 ` Romain Baeriswyl [this message]
2014-12-08  9:51 ` Wolfram Sang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=548567E3.6020101@alitech.com \
    --to=romain.baeriswyl@alitech.com \
    --cc=Romain.Baeriswyl@abilis.com \
    --cc=addy.ke@rock-chips.com \
    --cc=christian.ruppert@abilis.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dianders@chromium.org \
    --cc=galak@codeaurora.org \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=pawel.moll@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=skuribay@pobox.com \
    --cc=wsa@the-dreams.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox