Re: [PATCH 6/20] TTY: fix misspelling of current function in string

[Jiri Slaby <jslaby@suse.cz>]

On 12/08/2014, 10:18 AM, Joe Perches wrote:
> On Mon, 2014-12-08 at 09:49 +0100, Jiri Slaby wrote:
>> On 12/07/2014, 08:20 PM, Julia Lawall wrote:
>>> Replace the last argument of serial_paranoia_check by the actual function
>>> name.
> []
>>> diff --git a/drivers/tty/amiserial.c b/drivers/tty/amiserial.c
> []
>>> @@ -931,7 +931,7 @@ static void rs_send_xchar(struct tty_struct *tty, char ch)
>>>  	struct serial_state *info = tty->driver_data;
>>>          unsigned long flags;
>>>  
>>> -	if (serial_paranoia_check(info, tty->name, "rs_send_char"))
>>> +	if (serial_paranoia_check(info, tty->name, "rs_send_xchar"))
>>
>> I wonder, why not to use __func__ here too?
> 
> Nearly identical functions are used in amiserial and cyclades.

And I would bet more. They are mostly copy&paste drivers.

> Disabled in amiserial, enabled in cyclades.
> 
> It might be better to add it to some file like
> drivers/tty/debug_utils.h

Oh no, these should better die, not being generalized. But since the
drivers have nearly no users, if some at all, nobody wants to touch the
code.

-- 
js
suse labs