public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Daniel Borkmann <dborkman@redhat.com>
To: Paul Bolle <pebolle@tiscali.nl>
Cc: Christoph Jaeger <cj@linux.com>,
	yann.morin.1998@free.fr, linux-kbuild@vger.kernel.org,
	linux-kernel@vger.kernel.org, akpm@linux-foundation.org
Subject: Re: [PATCH 2/3] kconfig: remove undocumented type definition alias 'boolean'
Date: Tue, 09 Dec 2014 12:49:17 +0100	[thread overview]
Message-ID: <5486E1BD.4040809@redhat.com> (raw)
In-Reply-To: <1418073300.2058.63.camel@x220>

On 12/08/2014 10:15 PM, Paul Bolle wrote:
> On Mon, 2014-12-08 at 21:36 +0100, Paul Bolle wrote:
>> On Mon, 2014-12-08 at 20:41 +0100, Paul Bolle wrote:
>>> Well, it seems the treewide "boolean" cleanup should be done first.
>>> Removing support for "boolean" could than be a second, separate step.
>>> Just to ease review.
>>
>> This appears to have no effect on the .config files I generated for the
>> defconfig files in next-20141208. (After porting the patch and changing
>> those last booleans to bool, that is.) So that's good.
>>
>> If you'd resend as two patches on top of linux-next, I might add an
>> Acked-by: or a Tested-by:.
>
> My last mail on this series. To make sure the tree stays buildable that
> second patch to drop support for 'boolean' should only be applied a
> release or two after the cleanup patch has been applied. Otherwise we're
> bound to run into fun build errors in linux-next, and even mainline, for
> quite a few commits, aren't we? One tree still using boolean is all it
> takes...

Sounds like a good plan, thanks a lot for looking into it, Paul!

Meanwhile, also checkpatch.pl could emit a deprecate warning in case
a patch carries Kconfig code with 'boolean' in it, but I leave that
up to Christoph to decide. ;)

  reply	other threads:[~2014-12-09 11:49 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-08  1:49 [PATCH 0/3] remove undocumented type definition alias Christoph Jaeger
2014-12-08  1:49 ` [PATCH 1/3] kconfig: regenerate parser Christoph Jaeger
2014-12-08 20:28   ` Paul Bolle
2014-12-08  1:49 ` [PATCH 2/3] kconfig: remove undocumented type definition alias 'boolean' Christoph Jaeger
2014-12-08 18:51   ` Paul Bolle
2014-12-08 19:13     ` Paul Bolle
2014-12-08 19:16       ` Daniel Borkmann
2014-12-08 19:41         ` Paul Bolle
2014-12-08 20:36           ` Paul Bolle
2014-12-08 21:15             ` Paul Bolle
2014-12-09 11:49               ` Daniel Borkmann [this message]
2014-12-09 23:14                 ` Christoph Jaeger
2014-12-08  1:49 ` [PATCH 3/3] kconfig: rename S_BOOLEAN to S_BOOL for consistency Christoph Jaeger
2014-12-08 20:43   ` Paul Bolle
2014-12-08 20:20 ` [PATCH 0/3] remove undocumented type definition alias Paul Bolle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5486E1BD.4040809@redhat.com \
    --to=dborkman@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=cj@linux.com \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pebolle@tiscali.nl \
    --cc=yann.morin.1998@free.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox