From: David Ahern <dsahern@kernel.org>
To: Shiming Cheng <shiming.cheng@mediatek.com>,
jiri@resnulli.us, kuba@kernel.org, pabeni@redhat.com,
edumazet@google.com, davem@davemloft.net
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
Lena Wang <lena.wang@mediatek.com>
Subject: Re: [PATCH net v5] ipv6: fib6_rules: flush route cache when rule is changed
Date: Thu, 7 Mar 2024 12:36:53 -0700 [thread overview]
Message-ID: <5487d52a-31de-4422-b5ed-a59390d23ca0@kernel.org> (raw)
In-Reply-To: <20240307100157.29699-1-shiming.cheng@mediatek.com>
On 3/7/24 3:01 AM, Shiming Cheng wrote:
> When rule policy is changed, ipv6 socket cache is not refreshed.
> The sock's skb still uses a outdated route cache and was sent to
> a wrong interface.
>
> To avoid this error we should update fib node's version when
> rule is changed. Then skb's route will be reroute checked as
> route cache version is already different with fib node version.
> The route cache is refreshed to match the latest rule.
>
> Fixes: 101367c2f8c4 ("[IPV6]: Policy Routing Rules")
> Signed-off-by: Shiming Cheng <shiming.cheng@mediatek.com>
> Signed-off-by: Lena Wang <lena.wang@mediatek.com>
> ---
> v5:
> - rebase on the top of latest net/main branch.
> v4:
> - add "Fixes:" tag.
> - update subject as requested.
> v3:
> - update patch description and name format in commit message.
> v2:
> - modify flush function same way as ipv4 flush cache.
> - use tabs to aligh with existing code.
> ---
> ---
> net/ipv6/fib6_rules.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
Reviewed-by: David Ahern <dsahern@kernel.org>
next prev parent reply other threads:[~2024-03-07 19:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-07 10:01 [PATCH net v5] ipv6: fib6_rules: flush route cache when rule is changed Shiming Cheng
2024-03-07 19:36 ` David Ahern [this message]
2024-03-08 10:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5487d52a-31de-4422-b5ed-a59390d23ca0@kernel.org \
--to=dsahern@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=lena.wang@mediatek.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shiming.cheng@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox