public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] dma: imx-sdma: fix indentation
@ 2014-12-10  8:00 Asaf Vertz
  2014-12-11  4:50 ` Vinod Koul
  0 siblings, 1 reply; 4+ messages in thread
From: Asaf Vertz @ 2014-12-10  8:00 UTC (permalink / raw)
  To: vinod.koul; +Cc: dan.j.williams, dmaengine, linux-kernel

Fixed a coding style error, switch and case should be at the same indent

Signed-off-by: Asaf Vertz <asaf.vertz@tandemg.com>
---
 drivers/dma/imx-sdma.c |   18 +++++++++---------
 1 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c
index 88afc48..8729877 100644
--- a/drivers/dma/imx-sdma.c
+++ b/drivers/dma/imx-sdma.c
@@ -1301,15 +1301,15 @@ static void sdma_load_firmware(const struct firmware *fw, void *context)
 	if (header->ram_code_start + header->ram_code_size > fw->size)
 		goto err_firmware;
 	switch (header->version_major) {
-		case 1:
-			sdma->script_number = SDMA_SCRIPT_ADDRS_ARRAY_SIZE_V1;
-			break;
-		case 2:
-			sdma->script_number = SDMA_SCRIPT_ADDRS_ARRAY_SIZE_V2;
-			break;
-		default:
-			dev_err(sdma->dev, "unknown firmware version\n");
-			goto err_firmware;
+	case 1:
+		sdma->script_number = SDMA_SCRIPT_ADDRS_ARRAY_SIZE_V1;
+		break;
+	case 2:
+		sdma->script_number = SDMA_SCRIPT_ADDRS_ARRAY_SIZE_V2;
+		break;
+	default:
+		dev_err(sdma->dev, "unknown firmware version\n");
+		goto err_firmware;
 	}
 
 	addr = (void *)header + header->script_addrs_start;
-- 
1.7.0.4


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] dma: imx-sdma: fix indentation
  2014-12-10  8:00 [PATCH] dma: imx-sdma: fix indentation Asaf Vertz
@ 2014-12-11  4:50 ` Vinod Koul
  2014-12-11  7:23   ` Asaf Vertz
  0 siblings, 1 reply; 4+ messages in thread
From: Vinod Koul @ 2014-12-11  4:50 UTC (permalink / raw)
  To: Asaf Vertz; +Cc: dan.j.williams, dmaengine, linux-kernel

On Wed, Dec 10, 2014 at 10:00:36AM +0200, Asaf Vertz wrote:
> Fixed a coding style error, switch and case should be at the same indent
Please use the right subsystem name for the patches

Applied, now

Thanks
-- 
~Vinod

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] dma: imx-sdma: fix indentation
  2014-12-11  4:50 ` Vinod Koul
@ 2014-12-11  7:23   ` Asaf Vertz
  2014-12-15  8:15     ` Vinod Koul
  0 siblings, 1 reply; 4+ messages in thread
From: Asaf Vertz @ 2014-12-11  7:23 UTC (permalink / raw)
  To: Vinod Koul; +Cc: dan.j.williams, dmaengine, linux-kernel

On 12/11/2014 06:50 AM, Vinod Koul wrote:
> On Wed, Dec 10, 2014 at 10:00:36AM +0200, Asaf Vertz wrote:
>> Fixed a coding style error, switch and case should be at the same indent
> Please use the right subsystem name for the patches

what subsystem name I should have used?
I used the one from the last patches in the log

http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/log/drivers/dma/imx-sdma.c


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] dma: imx-sdma: fix indentation
  2014-12-11  7:23   ` Asaf Vertz
@ 2014-12-15  8:15     ` Vinod Koul
  0 siblings, 0 replies; 4+ messages in thread
From: Vinod Koul @ 2014-12-15  8:15 UTC (permalink / raw)
  To: Asaf Vertz; +Cc: dan.j.williams, dmaengine, linux-kernel

On Thu, Dec 11, 2014 at 09:23:23AM +0200, Asaf Vertz wrote:
> On 12/11/2014 06:50 AM, Vinod Koul wrote:
> > On Wed, Dec 10, 2014 at 10:00:36AM +0200, Asaf Vertz wrote:
> >> Fixed a coding style error, switch and case should be at the same indent
> > Please use the right subsystem name for the patches
> 
> what subsystem name I should have used?
> I used the one from the last patches in the log
> 
> http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/log/drivers/dma/imx-sdma.c

$ git llog drivers/dma/pl330.c | grep "dma: pl" |wc -l
22
$ git log drivers/dma/pl330.c | grep "dmaengine: pl" |wc -l
32

and these are last commits

$ git log --oneline drivers/dma/pl330.c
046209f61b5f dmaengine: pl330: update author info
cee42392f5f0 dmaengine: pl330: Correct device assignment.
6e4a2a83f958 dmaengine: pl330: Fix NULL pointer dereference on driver unbind
0f5ebabdd03b dmaengine: pl330: Fix NULL pointer dereference on probe failure
c3cb38f43cb9 dmaengine: pl330: Remove unused 'regs' variable in pl330_submit_req()
937cb2f2498d dmaengine: pl330: Remove non-NULL check for pl330_submit_req parameters
31c1e5a1350a dmaengine: Remove the context argument to the prep_dma_cyclic operation
b1e51d771fbc dmaengine: pl330: Check if the DMA descriptor is NULL
c26939e5204c dmaengine: pl330: Remove pl330_chan_ctrl()
8ed30a14265f dmaengine: pl330: Simplify marking a request as unused
9dc5a315fe51 dmaengine: pl330: Embed pl330_req directly into dma_pl330_desc
f6f2421c0a1c dmaengine: pl330: Merge dma_pl330_dmac and pl330_dmac structs
fbbcd9be96a0 dmaengine: pl330: Simplify is_manager()

-- 
~Vinod

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2014-12-15  8:15 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-12-10  8:00 [PATCH] dma: imx-sdma: fix indentation Asaf Vertz
2014-12-11  4:50 ` Vinod Koul
2014-12-11  7:23   ` Asaf Vertz
2014-12-15  8:15     ` Vinod Koul

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox