From: Chanwoo Choi <cw00.choi@samsung.com>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Cc: robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com,
ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
myungjoo.ham@samsung.com, grant.likely@linaro.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-sh@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH] extcon: add MAX3355 driver
Date: Thu, 11 Dec 2014 21:51:54 +0900 [thread overview]
Message-ID: <5489936A.3010409@samsung.com> (raw)
In-Reply-To: <54899264.30009@cogentembedded.com>
On 12/11/2014 09:47 PM, Sergei Shtylyov wrote:
> Hello.
>
> On 12/11/2014 4:46 AM, Chanwoo Choi wrote:
>
>> I reviewed this patch quickly. This driver has just two gpio without any registers for IP.
>
> Because there are no registers.
>
>> I wonder whether MAX3355E is separate chip to detect external connector
>
> Yes. I thought my description has made that clear...
>
>> or just use gpio of AP.
>
> What do you mean by AP?
> MAX3355 is indeed partly connected to GPIOs and partly to the USB pins.
>
>> Could you send the datasheet of MAX3355E to me?
>
> Looks like Geert has beaten me to it. :-)
>
>> Thanks,
>> Chanwoo Choi
>
OK, I'll review it.
Thanks,
Chanwoo Choi
next prev parent reply other threads:[~2014-12-11 12:52 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-10 23:28 [PATCH] extcon: add MAX3355 driver Sergei Shtylyov
2014-12-11 1:46 ` Chanwoo Choi
2014-12-11 9:07 ` Geert Uytterhoeven
2014-12-11 12:47 ` Sergei Shtylyov
2014-12-11 12:51 ` Chanwoo Choi [this message]
2014-12-17 0:31 ` Chanwoo Choi
2014-12-17 21:58 ` Sergei Shtylyov
2015-10-20 18:20 ` Sergei Shtylyov
2015-10-21 2:57 ` Chanwoo Choi
2015-10-22 22:41 ` Sergei Shtylyov
2015-10-23 5:56 ` Chanwoo Choi
2015-11-09 18:24 ` Sergei Shtylyov
2015-11-09 23:52 ` Chanwoo Choi
2015-11-10 11:03 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5489936A.3010409@samsung.com \
--to=cw00.choi@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=grant.likely@linaro.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=myungjoo.ham@samsung.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).