From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753563AbaLNObB (ORCPT <rfc822;w@1wt.eu>);
	Sun, 14 Dec 2014 09:31:01 -0500
Received: from userp1040.oracle.com ([156.151.31.81]:18701 "EHLO
	userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752860AbaLNObA (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Sun, 14 Dec 2014 09:31:00 -0500
Message-ID: <548D9F1A.3080701@oracle.com>
Date: Sun, 14 Dec 2014 09:30:50 -0500
From: Sasha Levin <sasha.levin@oracle.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0
MIME-Version: 1.0
To: Kirill Smelkov <kirr@nexedi.com>
CC: Ingo Molnar <mingo@kernel.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tools/liblockdep: Fix debug_check thinko in mutex destroy
References: <1418036879-31944-1-git-send-email-kirr@nexedi.com> <5485BCEA.30207@oracle.com> <20141214142148.GA2679@teco.navytux.spb.ru>
In-Reply-To: <20141214142148.GA2679@teco.navytux.spb.ru>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
X-Source-IP: ucsinet21.oracle.com [156.151.31.93]
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 12/14/2014 09:21 AM, Kirill Smelkov wrote:
> On Mon, Dec 08, 2014 at 09:59:54AM -0500, Sasha Levin wrote:
>> > On 12/08/2014 06:07 AM, Kirill Smelkov wrote:
>>> > > In mutex destroy code currently we pass to debug_check_no_locks_freed()
>>> > > 
>>> > >     [mem_from, mem_end)
>>> > > 
>>> > > address region. But debug_check_no_locks_freed() accepts
>>> > > 
>>> > >     mem_from, mem_*len*
>>> > > 
>>> > > i.e. second parameter is region length, not end address. And it was
>>> > > always so, starting from 2006 (fbb9ce95 "lockdep: core").
>>> > > 
>>> > > Fix it, or else on a mutex destroy we wrongly check
>>> > > much-wider-than-mutex region and can find not-yet-released other locks
>>> > > there and wrongly report BUGs on them.
>> > 
>> > Great catch, thanks!
> Thanks, where is this patch is/will-be applied?
> 
> I mean I could not find it neither in
> 
>     git://git.kernel.org/pub/scm/linux/kernel/git/sashal/linux.git
> 
> nor anywhere in linux-next nor in Linus's tree.

I'll send it to Ingo once v3.19-rc1 is out.


Thanks,
Sasha