From: Jens Axboe <axboe@kernel.dk>
To: Nicholas Krause <xerofoify@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers:block: Remove no longer needed FIXME comment for the function, add_disk in genhd.c
Date: Sun, 14 Dec 2014 19:40:45 -0700 [thread overview]
Message-ID: <548E4A2D.2050603@kernel.dk> (raw)
In-Reply-To: <1418526557-3295-1-git-send-email-xerofoify@gmail.com>
On 12/13/2014 08:09 PM, Nicholas Krause wrote:
> Removes unneeded fix me comment related to the function, add_disk needing error handling. The function clearly has supported this for a while and the comment is not longer needed
> for the function,add_disk in the file genhd.c.
But it doesn't, really. Proper error handling would be to unroll and
return the error, if it happens. Right now add_disk() can't return an error.
--
Jens Axboe
next parent reply other threads:[~2014-12-15 2:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1418526557-3295-1-git-send-email-xerofoify@gmail.com>
2014-12-15 2:40 ` Jens Axboe [this message]
[not found] ` <548E4B85.1040602@gmail.com>
2014-12-15 2:53 ` [PATCH] drivers:block: Remove no longer needed FIXME comment for the function, add_disk in genhd.c Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=548E4A2D.2050603@kernel.dk \
--to=axboe@kernel.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=xerofoify@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox