* Re: [PATCH] drivers:block: Remove no longer needed FIXME comment for the function, add_disk in genhd.c [not found] <1418526557-3295-1-git-send-email-xerofoify@gmail.com> @ 2014-12-15 2:40 ` Jens Axboe [not found] ` <548E4B85.1040602@gmail.com> 0 siblings, 1 reply; 2+ messages in thread From: Jens Axboe @ 2014-12-15 2:40 UTC (permalink / raw) To: Nicholas Krause; +Cc: linux-kernel On 12/13/2014 08:09 PM, Nicholas Krause wrote: > Removes unneeded fix me comment related to the function, add_disk needing error handling. The function clearly has supported this for a while and the comment is not longer needed > for the function,add_disk in the file genhd.c. But it doesn't, really. Proper error handling would be to unroll and return the error, if it happens. Right now add_disk() can't return an error. -- Jens Axboe ^ permalink raw reply [flat|nested] 2+ messages in thread
[parent not found: <548E4B85.1040602@gmail.com>]
* Re: [PATCH] drivers:block: Remove no longer needed FIXME comment for the function, add_disk in genhd.c [not found] ` <548E4B85.1040602@gmail.com> @ 2014-12-15 2:53 ` Jens Axboe 0 siblings, 0 replies; 2+ messages in thread From: Jens Axboe @ 2014-12-15 2:53 UTC (permalink / raw) To: nick; +Cc: linux-kernel On 12/14/2014 07:46 PM, nick wrote: > Jens, > After rechecking the function definition we can't return an error as add_disk is declared void. Should I change the function to an int and then return an error. My thinking was that there is no good way to return an error code without > a breakage in the functions that call add_disk. Please don't top post... It's a big job, it requires properly checking and updating all block drivers. But yes, that is what would be required in removing that TODO. -- Jens Axboe ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-12-15 2:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1418526557-3295-1-git-send-email-xerofoify@gmail.com>
2014-12-15 2:40 ` [PATCH] drivers:block: Remove no longer needed FIXME comment for the function, add_disk in genhd.c Jens Axboe
[not found] ` <548E4B85.1040602@gmail.com>
2014-12-15 2:53 ` Jens Axboe
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox