From: Jens Axboe <axboe@kernel.dk>
To: nick <xerofoify@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers:block: Remove no longer needed FIXME comment for the function, add_disk in genhd.c
Date: Sun, 14 Dec 2014 19:53:40 -0700 [thread overview]
Message-ID: <548E4D34.6000108@kernel.dk> (raw)
In-Reply-To: <548E4B85.1040602@gmail.com>
On 12/14/2014 07:46 PM, nick wrote:
> Jens,
> After rechecking the function definition we can't return an error as add_disk is declared void. Should I change the function to an int and then return an error. My thinking was that there is no good way to return an error code without
> a breakage in the functions that call add_disk.
Please don't top post...
It's a big job, it requires properly checking and updating all block
drivers. But yes, that is what would be required in removing that TODO.
--
Jens Axboe
prev parent reply other threads:[~2014-12-15 2:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1418526557-3295-1-git-send-email-xerofoify@gmail.com>
2014-12-15 2:40 ` [PATCH] drivers:block: Remove no longer needed FIXME comment for the function, add_disk in genhd.c Jens Axboe
[not found] ` <548E4B85.1040602@gmail.com>
2014-12-15 2:53 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=548E4D34.6000108@kernel.dk \
--to=axboe@kernel.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=xerofoify@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox