From: Randy Dunlap <rdunlap@infradead.org>
To: Platform Driver <platform-driver-x86@vger.kernel.org>,
Darren Hart <dvhart@infradead.org>
Cc: LKML <linux-kernel@vger.kernel.org>, Peter Feuerer <peter@piie.net>
Subject: [PATCH -next] platform/x86/acerhdf: still depends on THERMAL
Date: Mon, 15 Dec 2014 09:00:13 -0800 [thread overview]
Message-ID: <548F139D.4090901@infradead.org> (raw)
From: Randy Dunlap <rdunlap@infradead.org>
acerhdf uses thermal interfaces so it should depend on THERMAL.
It also should not select a thermal driver without checking that
THERMAL is enabled.
This fixes the following build errors when THERMAL=m and
ACERHDF=y.
drivers/built-in.o: In function `acerhdf_set_mode':
acerhdf.c:(.text+0x3e02e1): undefined reference to `thermal_zone_device_update'
drivers/built-in.o: In function `acerhdf_unbind':
acerhdf.c:(.text+0x3e052d): undefined reference to `thermal_zone_unbind_cooling_device'
drivers/built-in.o: In function `acerhdf_bind':
acerhdf.c:(.text+0x3e0593): undefined reference to `thermal_zone_bind_cooling_device'
drivers/built-in.o: In function `acerhdf_init':
acerhdf.c:(.init.text+0x1c2f5): undefined reference to `thermal_cooling_device_register'
acerhdf.c:(.init.text+0x1c360): undefined reference to `thermal_zone_device_register'
drivers/built-in.o: In function `acerhdf_unregister_thermal':
acerhdf.c:(.text.unlikely+0x3c67): undefined reference to `thermal_cooling_device_unregister'
acerhdf.c:(.text.unlikely+0x3c91): undefined reference to `thermal_zone_device_unregister'
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Peter Feuerer <peter@piie.net>
Cc: Darren Hart <dvhart@infradead.org>
---
drivers/platform/x86/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- linux-next-20141215.orig/drivers/platform/x86/Kconfig
+++ linux-next-20141215/drivers/platform/x86/Kconfig
@@ -38,8 +38,8 @@ config ACER_WMI
config ACERHDF
tristate "Acer Aspire One temperature and fan driver"
+ depends on ACPI && THERMAL
select THERMAL_GOV_BANG_BANG
- depends on ACPI
---help---
This is a driver for Acer Aspire One netbooks. It allows to access
the temperature sensor and to control the fan.
next reply other threads:[~2014-12-15 17:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-15 17:00 Randy Dunlap [this message]
2014-12-15 17:10 ` [PATCH -next] platform/x86/acerhdf: still depends on THERMAL Peter Feuerer
2014-12-15 17:33 ` Darren Hart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=548F139D.4090901@infradead.org \
--to=rdunlap@infradead.org \
--cc=dvhart@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peter@piie.net \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox