Re: [PATCH v4 1/6] iio: imu: Add support for Kionix KMX61 sensor

Daniel Baluta
2014-12-15T10:50:47Z

On Mon, Dec 15, 2014 at 12:43 AM, Hartmut Knaack <knaack.h@gmx.de> wrote:
> Daniel Baluta schrieb am 03.12.2014 um 14:31:
>> Minimal implementation for KMX61 6-axis accelerometer/magnetometer. It exports
>> raw accel/magn readings together with scale and sampling frequency.
>>
>> This driver uses two IIO devices one for accelerometer and one for magnetometer.
>>
> Hi Daniel,
> I think you dropped slightly too much code. In kmx61_set_odr() you stored the set
> odr bits in data->odr_bits previously, but now it's gone. But kmx61_get_odr()
> accesses data->odr_bits, which now remains in the state from driver initialization.
> Other than that, it's looking good.

Hi Hartmut,

Good catch. I will send a patch asap.
Thanks for feedback!

Daniel.