Re: [PATCH 1/2] drivers/regulator/core.c: Don't print error on EPROBE_DEFER

Mark Brown
2014-12-09T18:48:34Z

[-- Attachment #1: Type: text/plain, Size: 1202 bytes --]

On Tue, Dec 09, 2014 at 07:12:30PM +0100, Mike Looijmans wrote:
> On 12/09/2014 05:14 PM, Mark Brown wrote:

> >>If a regulator depends on another regulator that happens to be called
> >>later, the kernel always prints a message like this:
> >> reg-fixed-voltage regulator_sd1: Failed to find supply vin
> >>Since the deferral is not something fatal, nor even something the user
> >>may need to be aware about, reduce the message to debug level.

> Can we instead at least reduce it to WARN or INFO level then?

You appear to have deleted my reply here... one problem with your
suggestion is that it means we have to special case all error handling
on probe for deferral which isn't wonderful.

> I have to explain over and over again that there's no problem when that
> message comes along ten times in a row. And it causes people to overlook the
> messages that really are errors.

Can we do something with the log message that triggers on probe
deferral? There tends to be a learning curve with probe deferral but
the fact that it's generally extremely noisy tends to be useful - I
usually point people at that (not just in the context at regulators) and
tell them not to worry unless debugging.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]