* [PATCH] arch: powerpc: kvm: book3s_paired_singles.c: Remove unused function
@ 2014-12-07 22:29 Rickard Strandqvist
2014-12-17 12:13 ` Alexander Graf
0 siblings, 1 reply; 2+ messages in thread
From: Rickard Strandqvist @ 2014-12-07 22:29 UTC (permalink / raw)
To: Alexander Graf, Gleb Natapov
Cc: Rickard Strandqvist, Paolo Bonzini, Benjamin Herrenschmidt,
Paul Mackerras, Michael Ellerman, kvm-ppc, kvm, linuxppc-dev,
linux-kernel
Remove the function inst_set_field() that is not used anywhere.
This was partially found by using a static code analysis program called cppcheck.
Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
---
arch/powerpc/kvm/book3s_paired_singles.c | 8 --------
1 file changed, 8 deletions(-)
diff --git a/arch/powerpc/kvm/book3s_paired_singles.c b/arch/powerpc/kvm/book3s_paired_singles.c
index bfb8035..bd6ab16 100644
--- a/arch/powerpc/kvm/book3s_paired_singles.c
+++ b/arch/powerpc/kvm/book3s_paired_singles.c
@@ -352,14 +352,6 @@ static inline u32 inst_get_field(u32 inst, int msb, int lsb)
return kvmppc_get_field(inst, msb + 32, lsb + 32);
}
-/*
- * Replaces inst bits with ordering according to spec.
- */
-static inline u32 inst_set_field(u32 inst, int msb, int lsb, int value)
-{
- return kvmppc_set_field(inst, msb + 32, lsb + 32, value);
-}
-
bool kvmppc_inst_is_paired_single(struct kvm_vcpu *vcpu, u32 inst)
{
if (!(vcpu->arch.hflags & BOOK3S_HFLAG_PAIRED_SINGLE))
--
1.7.10.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] arch: powerpc: kvm: book3s_paired_singles.c: Remove unused function
2014-12-07 22:29 [PATCH] arch: powerpc: kvm: book3s_paired_singles.c: Remove unused function Rickard Strandqvist
@ 2014-12-17 12:13 ` Alexander Graf
0 siblings, 0 replies; 2+ messages in thread
From: Alexander Graf @ 2014-12-17 12:13 UTC (permalink / raw)
To: Rickard Strandqvist, Gleb Natapov
Cc: Paolo Bonzini, Benjamin Herrenschmidt, Paul Mackerras,
Michael Ellerman, kvm-ppc, kvm, linuxppc-dev, linux-kernel
On 07.12.14 23:29, Rickard Strandqvist wrote:
> Remove the function inst_set_field() that is not used anywhere.
>
> This was partially found by using a static code analysis program called cppcheck.
>
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Thanks, applied all unused function patches in KVM PPC code to
kvm-ppc-queue.
Alex
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-12-17 12:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-12-07 22:29 [PATCH] arch: powerpc: kvm: book3s_paired_singles.c: Remove unused function Rickard Strandqvist
2014-12-17 12:13 ` Alexander Graf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox