From: "H. Peter Anvin" <hpa@zytor.com>
To: "Yu, Fenghua" <fenghua.yu@intel.com>,
Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@linux.intel.com>,
Ingo Molnar <mingo@elte.hu>,
"Williamson, Glenn P" <glenn.p.williamson@intel.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>, x86 <x86@kernel.org>
Subject: Re: [PATCH v2] X86-32: Allocate 256 bytes for pgd in PAE paging
Date: Thu, 18 Dec 2014 10:00:14 -0800 [thread overview]
Message-ID: <5493162E.7060305@zytor.com> (raw)
In-Reply-To: <3E5A0FA7E9CA944F9D5414FEC6C712205A6C1D8F@ORSMSX106.amr.corp.intel.com>
>> 4*8 = 32 bytes, where did 256 bytes come from?
>
> You are right. It should be 32 bytes. I will change the wording in future patch. The real calculation in code is right though.
I don't know if it makes sense to round up to a cache line. My
suspicion is that it won't matter, as these fields will be read-mostly,
on the other hand, wasting 32 bytes isn't exactly a problem, either.
-hpa
prev parent reply other threads:[~2014-12-18 18:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-17 21:47 [PATCH v2] X86-32: Allocate 256 bytes for pgd in PAE paging Fenghua Yu
2014-12-18 0:25 ` Dave Hansen
2014-12-18 14:52 ` Christoph Lameter
2014-12-18 15:36 ` Dave Hansen
2014-12-18 17:25 ` H. Peter Anvin
2014-12-18 17:51 ` Yu, Fenghua
2014-12-18 18:00 ` H. Peter Anvin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5493162E.7060305@zytor.com \
--to=hpa@zytor.com \
--cc=fenghua.yu@intel.com \
--cc=glenn.p.williamson@intel.com \
--cc=hpa@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox