From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752499AbaLSLUd (ORCPT ); Fri, 19 Dec 2014 06:20:33 -0500 Received: from mx1.redhat.com ([209.132.183.28]:41311 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752156AbaLSLUb (ORCPT ); Fri, 19 Dec 2014 06:20:31 -0500 Message-ID: <549409F0.6030007@redhat.com> Date: Fri, 19 Dec 2014 12:20:16 +0100 From: Paolo Bonzini User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: Nicholas Krause , gleb@kernel.org CC: tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, x86@kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] KVM: x86: Remove FIXMEs in emulate.c for the function,task_switch_32 References: <1418955202-2463-1-git-send-email-xerofoify@gmail.com> In-Reply-To: <1418955202-2463-1-git-send-email-xerofoify@gmail.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 19/12/2014 03:13, Nicholas Krause wrote: > Remove FIXME comments about needing fault addresses to be returned. These > are propaagated from walk_addr_generic to gva_to_gpa and from there to > ops->read_std and ops->write_std. > > Signed-off-by: Nicholas Krause > --- > arch/x86/kvm/emulate.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/arch/x86/kvm/emulate.c b/arch/x86/kvm/emulate.c > index 169b09d..feaba46 100644 > --- a/arch/x86/kvm/emulate.c > +++ b/arch/x86/kvm/emulate.c > @@ -2750,7 +2750,6 @@ static int task_switch_32(struct x86_emulate_ctxt *ctxt, > ret = ops->read_std(ctxt, old_tss_base, &tss_seg, sizeof tss_seg, > &ctxt->exception); > if (ret != X86EMUL_CONTINUE) > - /* FIXME: need to provide precise fault address */ > return ret; > > save_state_to_tss32(ctxt, &tss_seg); > @@ -2759,13 +2758,11 @@ static int task_switch_32(struct x86_emulate_ctxt *ctxt, > ret = ops->write_std(ctxt, old_tss_base + eip_offset, &tss_seg.eip, > ldt_sel_offset - eip_offset, &ctxt->exception); > if (ret != X86EMUL_CONTINUE) > - /* FIXME: need to provide precise fault address */ > return ret; > > ret = ops->read_std(ctxt, new_tss_base, &tss_seg, sizeof tss_seg, > &ctxt->exception); > if (ret != X86EMUL_CONTINUE) > - /* FIXME: need to provide precise fault address */ > return ret; > > if (old_tss_sel != 0xffff) { > @@ -2776,7 +2773,6 @@ static int task_switch_32(struct x86_emulate_ctxt *ctxt, > sizeof tss_seg.prev_task_link, > &ctxt->exception); > if (ret != X86EMUL_CONTINUE) > - /* FIXME: need to provide precise fault address */ > return ret; > } > > Applied, thanks. Paolo