Re: [PATCH 3/3] i8k: Remove laptop specific config data (fan_mult, fan_max) from driver

Valdis.Kletnieks
2014-12-18T15:09:22Z

[-- Attachment #1: Type: text/plain, Size: 1153 bytes --]

On Thu, 18 Dec 2014 12:08:58 +0100, Pali Rohár said:

> So your BIOS cannot report nominal_rpm and because your machine=20
> is not in dmi list, all 3 patches do nothing for your machine.
>
> But you need to set multiplier to 1, right?
>
> What about this patch? (on top of 3/3)
>
> --- a/drivers/char/i8k.c
> +++ b/drivers/char/i8k.c
> @@ -850,6 +850,10 @@ static int __init i8k_probe(void)
> */
> for (fan = 0; fan < I8K_FAN_COUNT; ++fan) {
> i8k_fan_mult[fan] = I8K_FAN_DEFAULT_MULT;
> + if (i8k_get_fan_rpm(fan) > I8K_FAN_MAX_RPM) {
> + i8k_fan_mult[fan] = 1;
> + continue;
> + }
> for (val = 0; val < 256; ++val) {

Dell Latitude E6530, linux-next 20141208 plus the 3 patches you
posted on Nov 30 (support labels), plus the 4 of 3 patches in
this go around, and sensors reports:

i8k-virtual-0
Adapter: Virtual device
fan2: 2774 RPM

and under CPU load, that number rises to 3200 or so, so it seems to be
working....

So you probably should fold this into the current set of patches, and
feel free to put this in there:

Tested-By: Valdis Kletnieks <valdis.kletnieks@vt.edu>

[-- Attachment #2: Type: application/pgp-signature, Size: 848 bytes --]