* [PATCH] staging: vt6655: fix sparse warnings: incorrect argument type
@ 2014-12-21 13:56 Mike Krinkin
2014-12-21 14:59 ` Malcolm Priestley
0 siblings, 1 reply; 2+ messages in thread
From: Mike Krinkin @ 2014-12-21 13:56 UTC (permalink / raw)
To: gregkh, forest, tvboxspy, gclement; +Cc: devel, linux-kernel, Mike Krinkin
this patch fixes following sparse warnings:
drivers/staging/vt6655/device_main.c:1503:25: warning: incorrect type in argument 1 (different address spaces)
drivers/staging/vt6655/device_main.c:1503:25: expected void [noderef] <asn:2>*<noident>
drivers/staging/vt6655/device_main.c:1503:25: got struct vnt_private *
drivers/staging/vt6655/device_main.c:1503:25: warning: incorrect type in argument 2 (different address spaces)
drivers/staging/vt6655/device_main.c:1503:25: expected void [noderef] <asn:2>*<noident>
drivers/staging/vt6655/device_main.c:1503:25: got struct vnt_private *
drivers/staging/vt6655/device_main.c:1505:25: warning: incorrect type in argument 1 (different address spaces)
drivers/staging/vt6655/device_main.c:1505:25: expected void [noderef] <asn:2>*<noident>
drivers/staging/vt6655/device_main.c:1505:25: got struct vnt_private *
drivers/staging/vt6655/device_main.c:1505:25: warning: incorrect type in argument 2 (different address spaces)
drivers/staging/vt6655/device_main.c:1505:25: expected void [noderef] <asn:2>*<noident>
drivers/staging/vt6655/device_main.c:1505:25: got struct vnt_private *
Signed-off-by: Mike Krinkin <krinkin.m.u@gmail.com>
---
drivers/staging/vt6655/device_main.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/vt6655/device_main.c b/drivers/staging/vt6655/device_main.c
index 83e4162..ce616f9 100644
--- a/drivers/staging/vt6655/device_main.c
+++ b/drivers/staging/vt6655/device_main.c
@@ -1500,9 +1500,11 @@ static void vnt_bss_info_changed(struct ieee80211_hw *hw,
if (conf->enable_beacon) {
vnt_beacon_enable(priv, vif, conf);
- MACvRegBitsOn(priv, MAC_REG_TCR, TCR_AUTOBCNTX);
+ MACvRegBitsOn(priv->PortOffset, MAC_REG_TCR,
+ TCR_AUTOBCNTX);
} else {
- MACvRegBitsOff(priv, MAC_REG_TCR, TCR_AUTOBCNTX);
+ MACvRegBitsOff(priv->PortOffset, MAC_REG_TCR,
+ TCR_AUTOBCNTX);
}
}
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] staging: vt6655: fix sparse warnings: incorrect argument type
2014-12-21 13:56 [PATCH] staging: vt6655: fix sparse warnings: incorrect argument type Mike Krinkin
@ 2014-12-21 14:59 ` Malcolm Priestley
0 siblings, 0 replies; 2+ messages in thread
From: Malcolm Priestley @ 2014-12-21 14:59 UTC (permalink / raw)
To: Mike Krinkin, gregkh, forest, gclement; +Cc: devel, linux-kernel
On 21/12/14 13:56, Mike Krinkin wrote:
> this patch fixes following sparse warnings:
>
> drivers/staging/vt6655/device_main.c:1503:25: warning: incorrect type in argument 1 (different address spaces)
> drivers/staging/vt6655/device_main.c:1503:25: expected void [noderef] <asn:2>*<noident>
> drivers/staging/vt6655/device_main.c:1503:25: got struct vnt_private *
> drivers/staging/vt6655/device_main.c:1503:25: warning: incorrect type in argument 2 (different address spaces)
> drivers/staging/vt6655/device_main.c:1503:25: expected void [noderef] <asn:2>*<noident>
> drivers/staging/vt6655/device_main.c:1503:25: got struct vnt_private *
> drivers/staging/vt6655/device_main.c:1505:25: warning: incorrect type in argument 1 (different address spaces)
> drivers/staging/vt6655/device_main.c:1505:25: expected void [noderef] <asn:2>*<noident>
> drivers/staging/vt6655/device_main.c:1505:25: got struct vnt_private *
> drivers/staging/vt6655/device_main.c:1505:25: warning: incorrect type in argument 2 (different address spaces)
> drivers/staging/vt6655/device_main.c:1505:25: expected void [noderef] <asn:2>*<noident>
> drivers/staging/vt6655/device_main.c:1505:25: got struct vnt_private *
Good catch
also needed for 3.19
Thanks
Malcolm
>
> Signed-off-by: Mike Krinkin <krinkin.m.u@gmail.com>
> ---
> drivers/staging/vt6655/device_main.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/vt6655/device_main.c b/drivers/staging/vt6655/device_main.c
> index 83e4162..ce616f9 100644
> --- a/drivers/staging/vt6655/device_main.c
> +++ b/drivers/staging/vt6655/device_main.c
> @@ -1500,9 +1500,11 @@ static void vnt_bss_info_changed(struct ieee80211_hw *hw,
> if (conf->enable_beacon) {
> vnt_beacon_enable(priv, vif, conf);
>
> - MACvRegBitsOn(priv, MAC_REG_TCR, TCR_AUTOBCNTX);
> + MACvRegBitsOn(priv->PortOffset, MAC_REG_TCR,
> + TCR_AUTOBCNTX);
> } else {
> - MACvRegBitsOff(priv, MAC_REG_TCR, TCR_AUTOBCNTX);
> + MACvRegBitsOff(priv->PortOffset, MAC_REG_TCR,
> + TCR_AUTOBCNTX);
> }
> }
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-12-21 14:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-12-21 13:56 [PATCH] staging: vt6655: fix sparse warnings: incorrect argument type Mike Krinkin
2014-12-21 14:59 ` Malcolm Priestley
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox