From: Jiang Liu <jiang.liu@linux.intel.com>
To: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, Christoph Lameter <cl@linux.com>,
Tejun Heo <tj@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arch: x86: kernel: apb_timer.c: Remove unused function
Date: Mon, 22 Dec 2014 11:18:52 +0800 [thread overview]
Message-ID: <54978D9C.9070605@linux.intel.com> (raw)
In-Reply-To: <1419166698-2470-1-git-send-email-rickard_strandqvist@spectrumdigital.se>
On 2014/12/21 20:58, Rickard Strandqvist wrote:
> Remove the function is_apbt_capable() that is not used anywhere.
>
> This was partially found by using a static code analysis program called cppcheck.
>
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
> ---
> arch/x86/kernel/apb_timer.c | 8 --------
> 1 file changed, 8 deletions(-)
>
> diff --git a/arch/x86/kernel/apb_timer.c b/arch/x86/kernel/apb_timer.c
> index b708738..6a7c23f 100644
> --- a/arch/x86/kernel/apb_timer.c
> +++ b/arch/x86/kernel/apb_timer.c
> @@ -135,14 +135,6 @@ static inline void apbt_clear_mapping(void)
> apbt_virt_address = NULL;
> }
>
> -/*
> - * APBT timer interrupt enable / disable
> - */
> -static inline int is_apbt_capable(void)
> -{
> - return apbt_virt_address ? 1 : 0;
> -}
> -
> static int __init apbt_clockevent_register(void)
> {
> struct sfi_timer_table_entry *mtmr;
>
Reviewed-by: Jiang Liu <jiang.liu@linux.intel.com>
next prev parent reply other threads:[~2014-12-22 3:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-21 12:58 [PATCH] arch: x86: kernel: apb_timer.c: Remove unused function Rickard Strandqvist
2014-12-22 3:18 ` Jiang Liu [this message]
2014-12-23 14:36 ` [tip:x86/platform] x86/platform: Remove unused function from apb_timer.c tip-bot for Rickard Strandqvist
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54978D9C.9070605@linux.intel.com \
--to=jiang.liu@linux.intel.com \
--cc=cl@linux.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rickard_strandqvist@spectrumdigital.se \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox