* [PATCH] arch: x86: kernel: apb_timer.c: Remove unused function
@ 2014-12-21 12:58 Rickard Strandqvist
2014-12-22 3:18 ` Jiang Liu
2014-12-23 14:36 ` [tip:x86/platform] x86/platform: Remove unused function from apb_timer.c tip-bot for Rickard Strandqvist
0 siblings, 2 replies; 3+ messages in thread
From: Rickard Strandqvist @ 2014-12-21 12:58 UTC (permalink / raw)
To: Thomas Gleixner, Ingo Molnar
Cc: Rickard Strandqvist, H. Peter Anvin, x86, Christoph Lameter,
Tejun Heo, Jiang Liu, linux-kernel
Remove the function is_apbt_capable() that is not used anywhere.
This was partially found by using a static code analysis program called cppcheck.
Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
---
arch/x86/kernel/apb_timer.c | 8 --------
1 file changed, 8 deletions(-)
diff --git a/arch/x86/kernel/apb_timer.c b/arch/x86/kernel/apb_timer.c
index b708738..6a7c23f 100644
--- a/arch/x86/kernel/apb_timer.c
+++ b/arch/x86/kernel/apb_timer.c
@@ -135,14 +135,6 @@ static inline void apbt_clear_mapping(void)
apbt_virt_address = NULL;
}
-/*
- * APBT timer interrupt enable / disable
- */
-static inline int is_apbt_capable(void)
-{
- return apbt_virt_address ? 1 : 0;
-}
-
static int __init apbt_clockevent_register(void)
{
struct sfi_timer_table_entry *mtmr;
--
1.7.10.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] arch: x86: kernel: apb_timer.c: Remove unused function
2014-12-21 12:58 [PATCH] arch: x86: kernel: apb_timer.c: Remove unused function Rickard Strandqvist
@ 2014-12-22 3:18 ` Jiang Liu
2014-12-23 14:36 ` [tip:x86/platform] x86/platform: Remove unused function from apb_timer.c tip-bot for Rickard Strandqvist
1 sibling, 0 replies; 3+ messages in thread
From: Jiang Liu @ 2014-12-22 3:18 UTC (permalink / raw)
To: Rickard Strandqvist, Thomas Gleixner, Ingo Molnar
Cc: H. Peter Anvin, x86, Christoph Lameter, Tejun Heo, linux-kernel
On 2014/12/21 20:58, Rickard Strandqvist wrote:
> Remove the function is_apbt_capable() that is not used anywhere.
>
> This was partially found by using a static code analysis program called cppcheck.
>
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
> ---
> arch/x86/kernel/apb_timer.c | 8 --------
> 1 file changed, 8 deletions(-)
>
> diff --git a/arch/x86/kernel/apb_timer.c b/arch/x86/kernel/apb_timer.c
> index b708738..6a7c23f 100644
> --- a/arch/x86/kernel/apb_timer.c
> +++ b/arch/x86/kernel/apb_timer.c
> @@ -135,14 +135,6 @@ static inline void apbt_clear_mapping(void)
> apbt_virt_address = NULL;
> }
>
> -/*
> - * APBT timer interrupt enable / disable
> - */
> -static inline int is_apbt_capable(void)
> -{
> - return apbt_virt_address ? 1 : 0;
> -}
> -
> static int __init apbt_clockevent_register(void)
> {
> struct sfi_timer_table_entry *mtmr;
>
Reviewed-by: Jiang Liu <jiang.liu@linux.intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* [tip:x86/platform] x86/platform: Remove unused function from apb_timer.c
2014-12-21 12:58 [PATCH] arch: x86: kernel: apb_timer.c: Remove unused function Rickard Strandqvist
2014-12-22 3:18 ` Jiang Liu
@ 2014-12-23 14:36 ` tip-bot for Rickard Strandqvist
1 sibling, 0 replies; 3+ messages in thread
From: tip-bot for Rickard Strandqvist @ 2014-12-23 14:36 UTC (permalink / raw)
To: linux-tip-commits
Cc: linux-kernel, cl, rickard_strandqvist, mingo, tj, hpa, jiang.liu,
tglx
Commit-ID: 2b261f9f7bd9333e62140ca7e02a2f4ffec5e44f
Gitweb: http://git.kernel.org/tip/2b261f9f7bd9333e62140ca7e02a2f4ffec5e44f
Author: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
AuthorDate: Sun, 21 Dec 2014 13:58:18 +0100
Committer: Ingo Molnar <mingo@kernel.org>
CommitDate: Tue, 23 Dec 2014 10:43:35 +0100
x86/platform: Remove unused function from apb_timer.c
Remove the function is_apbt_capable() that is not used anywhere.
This was partially found by using a static code analysis program
called 'cppcheck'.
Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Reviewed-by: Jiang Liu <jiang.liu@linux.intel.com>
Cc: Christoph Lameter <cl@linux.com>
Cc: Tejun Heo <tj@kernel.org>
Link: http://lkml.kernel.org/r/1419166698-2470-1-git-send-email-rickard_strandqvist@spectrumdigital.se
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
arch/x86/kernel/apb_timer.c | 8 --------
1 file changed, 8 deletions(-)
diff --git a/arch/x86/kernel/apb_timer.c b/arch/x86/kernel/apb_timer.c
index b708738..6a7c23f 100644
--- a/arch/x86/kernel/apb_timer.c
+++ b/arch/x86/kernel/apb_timer.c
@@ -135,14 +135,6 @@ static inline void apbt_clear_mapping(void)
apbt_virt_address = NULL;
}
-/*
- * APBT timer interrupt enable / disable
- */
-static inline int is_apbt_capable(void)
-{
- return apbt_virt_address ? 1 : 0;
-}
-
static int __init apbt_clockevent_register(void)
{
struct sfi_timer_table_entry *mtmr;
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-12-23 14:37 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-12-21 12:58 [PATCH] arch: x86: kernel: apb_timer.c: Remove unused function Rickard Strandqvist
2014-12-22 3:18 ` Jiang Liu
2014-12-23 14:36 ` [tip:x86/platform] x86/platform: Remove unused function from apb_timer.c tip-bot for Rickard Strandqvist
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox