RE: [PATCH 0/3] usb: chipidea: add one errata for revision 2.40a

Peter Chen
2014-12-24T09:00:46Z

>
> On 12/23/2014 05:39 AM, Peter Chen wrote:
> > On Mon, Dec 22, 2014 at 06:39:42PM +0530, Sanchayan Maity wrote:
> >> On 12/22/2014 06:48 AM, Peter Chen wrote:
> >>> On Fri, Dec 19, 2014 at 03:25:26PM +0530, Sanchayan Maity wrote:
> >>>> The first two patches add identification register API's. These can
> >>>> be used to get controller's revision.
> >>>>
> >>>> The third patch implements an errata for revision 2.40a. Not sure
> >>>> which other SOCs implement this version of the Chipidea core but
> >>>> this fixes the usb client issue observed on Vybrids. The patch was
> >>>> tested on a Toradex Colibri VF61 module with the 3.18 kernel. iperf
> >>>> tests ran for three hours plus, with these patches applied have
> >>>> found the USB client connection to be now reliable.
> >>>
> >>> Would you help do a overnight test? It is passed, I will queue them,
> >>> thanks.
> >>
> >> Yes definitely I can help with the testing. Are you looking for iperf
> >> tests only or something else? iperf tests running for 12 or 24 hours
> >> will do? I will need a bit of time to set things up here, as I am
> >> away from work, but, ya I will do them.
> >>
> >
> > iperf for g_ncm or g_ether and bonnie++ for g_mass_storage if you can
> > run, thanks.
>
> The tests were run on a Toradex Colibri Vybrid VF61 module having 256MB
> RAM with the 3.18 kernel.
>
> The iperf tests ran for around 19 hours before I stopped it. A snip of the iperf
> tests is below. Used the Ethernet Gadget class for this.
>
> [ 4] 70453.0-70453.5 sec 6.89 MBytes 116 Mbits/sec
> [ 4] 70453.5-70454.0 sec 6.83 MBytes 115 Mbits/sec
> [ 4] 70454.0-70454.5 sec 6.84 MBytes 115 Mbits/sec
> [ 4] 70454.5-70455.0 sec 6.89 MBytes 116 Mbits/sec
> [ 4] 70455.0-70455.5 sec 6.90 MBytes 116 Mbits/sec
> [ 4] 70455.5-70456.0 sec 6.90 MBytes 116 Mbits/sec
> [ 4] 70456.0-70456.5 sec 6.82 MBytes 114 Mbits/sec
> [ 4] 70456.5-70457.0 sec 6.80 MBytes 114 Mbits/sec
> [ 4] 70457.0-70457.5 sec 6.89 MBytes 116 Mbits/sec
> [ 4] 70457.5-70458.0 sec 6.85 MBytes 115 Mbits/sec
> [ 4] 70458.0-70458.5 sec 6.82 MBytes 114 Mbits/sec
> [ 4] 70458.5-70459.0 sec 6.82 MBytes 114 Mbits/sec
> [ 4] 0.0-70459.2 sec 946 GBytes 115 Mbits/sec
>
> Ran bonnie++ on gadget mass storage. CPU usage around the time of running
> this test was mostly around the 90% mark with the minimum at 60% plus.
> The storage directory was formatted with ext4. bonnie++ version used is
> 1.97 and was installed from the Arch repositories with pacman.
>
> The size of the file being specified for "lun" storage is 512MB. I have specified
> 128MB RAM in the below run with the size of file for IO performance as 256MB.
> Without this bonnie++ was giving me an error around the "Writing intelligently"
> point. I assume this has to do with the file size bonnie++ uses for testing.
>

What's your backfile for mass storage, mmc?
You mean without this errata, running bonnie++ will meet error?

> [sanchayan@Sanchayan-Arch ~]$ sudo /usr/bin/bonnie++ -m Vybrid -r 128 -d
> /var/run/media/sanchayan/Vybrid/ -x 5 -u root -n 0 -s 256 Using uid:0, gid:0.
> format_version,bonnie_version,name,concurrency,seed,file_size,io_chunk_si
> ze,putc,putc_cpu,put_block,put_block_cpu,rewrite,rewrite_cpu,getc,getc_cp
> u,get_block,get_block_cpu,seeks,seeks_cpu,num_files,max_size,min_size,nu
> m_dirs,file_chunk_size,seq_create,seq_create_cpu,seq_stat,seq_stat_cpu,se
> q_del,seq_del_cpu,ran_create,ran_create_cpu,ran_stat,ran_stat_cpu,ran_del
> ,ran_del_cpu,putc_latency,put_block_latency,rewrite_latency,getc_latency,ge
> t_block_latency,seeks_latency,seq_create_latency,seq_stat_latency,seq_del_
> latency,ran_create_latency,ran_stat_latency,ran_del_latency
> Writing a byte at a time...done
> Writing intelligently...done
> Rewriting...done
> Reading a byte at a time...done
> Reading intelligently...done
> start 'em...done...done...done...done...done...
> 1.97,1.97,Vybrid,1,1419409300,256M,,659,87,8341,1,9401,0,4222,98,+++++,+++,
> 3539,19,,,,,,,,,,,,,,,,,,23042us,66us,59us,4482us,79us,475us,,,,,,
> Writing a byte at a time...done
> Writing intelligently...done
> Rewriting...done
> Reading a byte at a time...done
> Reading intelligently...done
> start 'em...done...done...done...done...done...
> 1.97,1.97,Vybrid,1,1419409300,256M,,661,90,7689,1,9071,0,4011,99,+++++,+++,
> 3426,20,,,,,,,,,,,,,,,,,,15406us,64us,62us,4667us,23us,10030us,,,,,,
> Writing a byte at a time...done
> Writing intelligently...done
> Rewriting...done
> Reading a byte at a time...done
> Reading intelligently...done
> start 'em...done...done...done...done...done...
> 1.97,1.97,Vybrid,1,1419409300,256M,,673,89,8117,1,9451,0,3879,98,+++++,+++,
> 3355,22,,,,,,,,,,,,,,,,,,14210us,45us,69us,5069us,21us,10052us,,,,,,
> Writing a byte at a time...done
> Writing intelligently...done
> Rewriting...done
> Reading a byte at a time...done
> Reading intelligently...done
> start 'em...done...done...done...done...done...
> 1.97,1.97,Vybrid,1,1419409300,256M,,668,89,7801,1,9343,0,4099,98,+++++,+++,
> 3336,16,,,,,,,,,,,,,,,,,,17019us,44us,75us,4920us,20us,10234us,,,,,,
> Writing a byte at a time...done
> Writing intelligently...done
> Rewriting...done
> Reading a byte at a time...done
> Reading intelligently...done
> start 'em...done...done...done...done...done...
> 1.97,1.97,Vybrid,1,1419409300,256M,,676,89,7953,1,9494,0,3878,98,+++++,+++,
> 3396,22,,,,,,,,,,,,,,,,,,14080us,56us,42us,5177us,23us,12224us,,,,,,
>
> Let me know if this is OK.

Thanks for making and testing the patch, it is really a good job.
I will queue this patch in my chipidea tree.

Peter