Re: [PATCH 1/2] x86, mpx: explicitly disable 32-bit MPX support on 64-bit kernels

Andy Lutomirski
2014-12-22T20:27:59Z

On Mon, Dec 22, 2014 at 12:21 PM, Dave Hansen <dave@sr71.net> wrote:
> On 12/22/2014 12:17 PM, Andy Lutomirski wrote:
>>> > /*
>>> > + * 32-bit binaries on 64-bit kernels are currently
>>> > + * unsupported.
>>> > + */
>>> > + if (IS_ENABLED(CONFIG_X86_64) && test_thread_flag(TIF_IA32))
>>> > + return MPX_INVALID_BOUNDS_DIR;
>> Should this check mm->ia32_compat instead?
>
> set_personality_64bit/ia32() seem to make that and TIF_IA32 awfully
> equivalent. Is there a specific reason for wanting it done this way?

My general desire to remove various bogus TIF_IA32 references. But
this is only temporary, so I don't really care.

--Andy

--
Andy Lutomirski
AMA Capital Management, LLC