* [PATCH] xen/time: Remove unnecessary BUG_ON(preemptible()) in xen_setup_timer()
@ 2014-12-22 18:33 Boris Ostrovsky
2014-12-23 10:34 ` [Xen-devel] " David Vrabel
0 siblings, 1 reply; 2+ messages in thread
From: Boris Ostrovsky @ 2014-12-22 18:33 UTC (permalink / raw)
To: david.vrabel, konrad.wilk; +Cc: xen-devel, linux-kernel, boris.ostrovsky
There is no reason for having it and, with commit 250a1ac685f1 ("x86,
smpboot: Remove pointless preempt_disable() in
native_smp_prepare_cpus()"), it prevents HVM guests from booting.
Signed-off-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
---
arch/x86/xen/time.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/arch/x86/xen/time.c b/arch/x86/xen/time.c
index f473d26..23019b4 100644
--- a/arch/x86/xen/time.c
+++ b/arch/x86/xen/time.c
@@ -458,8 +458,6 @@ void xen_setup_timer(int cpu)
void xen_setup_cpu_clockevents(void)
{
- BUG_ON(preemptible());
-
clockevents_register_device(this_cpu_ptr(&xen_clock_events.evt));
}
--
1.9.3
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [Xen-devel] [PATCH] xen/time: Remove unnecessary BUG_ON(preemptible()) in xen_setup_timer()
2014-12-22 18:33 [PATCH] xen/time: Remove unnecessary BUG_ON(preemptible()) in xen_setup_timer() Boris Ostrovsky
@ 2014-12-23 10:34 ` David Vrabel
0 siblings, 0 replies; 2+ messages in thread
From: David Vrabel @ 2014-12-23 10:34 UTC (permalink / raw)
To: Boris Ostrovsky, david.vrabel, konrad.wilk; +Cc: xen-devel, linux-kernel
On 22/12/14 18:33, Boris Ostrovsky wrote:
> There is no reason for having it and, with commit 250a1ac685f1 ("x86,
> smpboot: Remove pointless preempt_disable() in
> native_smp_prepare_cpus()"), it prevents HVM guests from booting.
Applied to stable/for-linus-3.19, thanks.
For arch-specific fixes I prefer the arch in the subject. e.g., "x86/xen:".
David
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-12-23 10:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-12-22 18:33 [PATCH] xen/time: Remove unnecessary BUG_ON(preemptible()) in xen_setup_timer() Boris Ostrovsky
2014-12-23 10:34 ` [Xen-devel] " David Vrabel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox