From: Sylwester Nawrocki <s.nawrocki@samsung.com>
To: Chanwoo Choi <cw00.choi@samsung.com>
Cc: tomasz.figa@gmail.com, kgene.kim@samsung.com,
kyungmin.park@samsung.com, inki.dae@samsung.com,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/3] clk: samsung: Use samsung_cmu_register_one() to simplify code
Date: Tue, 23 Dec 2014 14:41:39 +0100 [thread overview]
Message-ID: <54997113.2080804@samsung.com> (raw)
In-Reply-To: <1419320423-19228-1-git-send-email-cw00.choi@samsung.com>
Hi Chanwoo,
On 23/12/14 08:40, Chanwoo Choi wrote:
> This patch-set uses the samsung_cmu_register_one() function to simplify the
> clock driver for Exynos3250/Exynos4415 SoC and change return value of
> samsung_cmu_register_one() because some clock driver may need the instance
> of samsung_clk_provider structure.
>
> Chanwoo Choi (3):
> clk: samsung: Changes the return value of samsung_cmu_register_one()
> clk: samsung: exynos3250: Use samsung_cmu_register_one() to simplify code
> clk: samsung: exynos4415: Use samsung_cmu_register_one() to simplify code
>
> drivers/clk/samsung/clk-exynos3250.c | 217 ++++++++---------------------------
> drivers/clk/samsung/clk-exynos4415.c | 216 ++++++++--------------------------
> drivers/clk/samsung/clk.c | 13 ++-
> drivers/clk/samsung/clk.h | 3 +-
> 4 files changed, 107 insertions(+), 342 deletions(-)
Thanks for the cleanup, I've queued that for 3.20. And fixed a minor
checkpatch warning when applying:
ERROR: "foo* __init bar" should be "foo * __init bar"
#29: FILE: drivers/clk/samsung/clk.c:377:
+struct samsung_clk_provider* __init samsung_cmu_register_one(
total: 1 errors, 0 warnings, 42 lines checked
0001-clk-samsung-Changes-the-return-value-of-samsung_cmu_.patch has style
problems, please review.
--
Thanks,
Sylwester
next prev parent reply other threads:[~2014-12-23 13:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-23 7:40 [PATCH 0/3] clk: samsung: Use samsung_cmu_register_one() to simplify code Chanwoo Choi
2014-12-23 7:40 ` [PATCH 1/3] clk: samsung: Changes the return value of samsung_cmu_register_one() Chanwoo Choi
2014-12-23 7:40 ` [PATCH 2/3] clk: samsung: exynos3250: Use samsung_cmu_register_one() to simplify code Chanwoo Choi
2014-12-23 7:40 ` [PATCH 3/3] clk: samsung: exynos4415: " Chanwoo Choi
2014-12-23 13:41 ` Sylwester Nawrocki [this message]
2014-12-23 14:57 ` [PATCH 0/3] clk: samsung: " Chanwoo Choi
2014-12-23 15:05 ` Sylwester Nawrocki
2014-12-23 15:09 ` Chanwoo Choi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54997113.2080804@samsung.com \
--to=s.nawrocki@samsung.com \
--cc=cw00.choi@samsung.com \
--cc=inki.dae@samsung.com \
--cc=kgene.kim@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=tomasz.figa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox