From: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
To: Michael Ellerman <mpe@ellerman.id.au>
Cc: Namhyung Kim <namhyung@kernel.org>,
Steven Rostedt <rostedt@goodmis.org>, Pavel Machek <pavel@ucw.cz>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ftracetest: Replace usleep with sleep 0.000001
Date: Wed, 24 Dec 2014 10:00:51 +0900 [thread overview]
Message-ID: <549A1043.30003@hitachi.com> (raw)
In-Reply-To: <1419318514.32430.1.camel@ellerman.id.au>
(2014/12/23 16:08), Michael Ellerman wrote:
> On Tue, 2014-12-23 at 13:21 +0900, Namhyung Kim wrote:
>> On Sat, Dec 20, 2014 at 05:07:25PM -0500, Steven Rostedt wrote:
>>> On Sat, 20 Dec 2014 21:42:13 +0100
>>> Pavel Machek <pavel@ucw.cz> wrote:
>>>
>>>> On Wed 2014-12-10 15:38:27, Michael Ellerman wrote:
>>>>> usleep is a Fedoraism, it's not generally available on Debian based
>>>>> systems AFAICS.
>>>>>
>>>>> GNU sleep accepts a floating point argument, so use that instead.
>>>>>
>>>>> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
>>>>
>>>> Could ftrace user interface be enhanced not to need random delays?
>>>>
>>>
>>> Not sure what you are talking about. These "random delays" are not for
>>> the interface, but instead to force some events to happen and to make
>>> sure they did.
>>>
>>> As the subject states, this is for "ftracetest" which is the selftests
>>> for ftrace.
>>>
>>> The usleep is basically a "do something to trigger events", and we
>>> don't want to wait long in doing it.
>>
>> Right. AFAIK what ftracetest expects is a scheduler event so it
>> doesn't need to be the [u]sleep.
>
> Would /bin/true work in that case?
As other scripts doing, just (echo "forked") would be enough. It forks
sub shell and wait for that.
Please check test.d/kprobe/kprobe_args.tc
Thanks!
--
Masami HIRAMATSU
Software Platform Research Dept. Linux Technology Research Center
Hitachi, Ltd., Yokohama Research Laboratory
E-mail: masami.hiramatsu.pt@hitachi.com
next prev parent reply other threads:[~2014-12-24 1:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-10 4:38 [PATCH] ftracetest: Replace usleep with sleep 0.000001 Michael Ellerman
2014-12-10 8:19 ` Namhyung Kim
2014-12-11 5:12 ` Masami Hiramatsu
2014-12-11 23:39 ` Michael Ellerman
2014-12-20 20:42 ` Pavel Machek
2014-12-20 22:07 ` Steven Rostedt
2014-12-23 4:21 ` Namhyung Kim
2014-12-23 7:08 ` Michael Ellerman
2014-12-24 1:00 ` Masami Hiramatsu [this message]
2014-12-25 23:17 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=549A1043.30003@hitachi.com \
--to=masami.hiramatsu.pt@hitachi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mpe@ellerman.id.au \
--cc=namhyung@kernel.org \
--cc=pavel@ucw.cz \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox