* [PATCH] doc fix - brlock was removed in the 3.13 kernel series
@ 2014-12-25 11:29 Nicholas Mc Guire
2014-12-25 14:42 ` Rik van Riel
0 siblings, 1 reply; 2+ messages in thread
From: Nicholas Mc Guire @ 2014-12-25 11:29 UTC (permalink / raw)
To: Al Viro
Cc: John Stultz, Ingo Molnar, Stephen Boyd, Trond Myklebust,
Rik van Riel, Mathieu Desnoyers, linux-kernel, Nicholas Mc Guire
The brlock was completely removed in the 3.13 kernel series.
see commit 0f6ed63b1707 ("no need to keep brlock macros anymore...")
It seems that documentation in seqlock.h was not updated to reflect
this. This patch drops the (hopefully last) false brlock reference.
All remaining references to brlock refer to byte-range locks (notably
in cifs) and not to "Big Reader Lock" and should be correct.
patch is against 3.19.0-rc1 linux-next
Signed-off-by: Nicholas Mc Guire <der.herr@hofr.at>
---
include/linux/seqlock.h | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/include/linux/seqlock.h b/include/linux/seqlock.h
index f5df8f6..af7f5e9 100644
--- a/include/linux/seqlock.h
+++ b/include/linux/seqlock.h
@@ -13,9 +13,8 @@
* from going forward. Unlike the regular rwlock, the read lock here is
* exclusive so that only one locking reader can get it.
*
- * This is not as cache friendly as brlock. Also, this may not work well
- * for data that contains pointers, because any writer could
- * invalidate a pointer that a reader was following.
+ * This may not work well for data that contains pointers, because any
+ * writer could invalidate a pointer that a reader was following.
*
* Expected non-blocking reader usage:
* do {
--
1.7.10.4
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] doc fix - brlock was removed in the 3.13 kernel series
2014-12-25 11:29 [PATCH] doc fix - brlock was removed in the 3.13 kernel series Nicholas Mc Guire
@ 2014-12-25 14:42 ` Rik van Riel
0 siblings, 0 replies; 2+ messages in thread
From: Rik van Riel @ 2014-12-25 14:42 UTC (permalink / raw)
To: Nicholas Mc Guire, Al Viro
Cc: John Stultz, Ingo Molnar, Stephen Boyd, Trond Myklebust,
Mathieu Desnoyers, linux-kernel
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 12/25/2014 06:29 AM, Nicholas Mc Guire wrote:
> The brlock was completely removed in the 3.13 kernel series. see
> commit 0f6ed63b1707 ("no need to keep brlock macros anymore...")
>
> It seems that documentation in seqlock.h was not updated to
> reflect this. This patch drops the (hopefully last) false brlock
> reference. All remaining references to brlock refer to byte-range
> locks (notably in cifs) and not to "Big Reader Lock" and should be
> correct.
>
> patch is against 3.19.0-rc1 linux-next
>
> Signed-off-by: Nicholas Mc Guire <der.herr@hofr.at>
Reviewed-by: Rik van Riel <riel@redhat.com>
- --
All rights reversed
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
iQEcBAEBAgAGBQJUnCJVAAoJEM553pKExN6DTl4IALfePxNFoRphS8CmLbONtqmi
Bs4gu9ngJq6BLenk6bOF5wfMCRTBXHagWnn14wrjjZOFBkh9Fh+Zy+8GKS31rwUL
GNsCdOUoSBRts2xXMCIxX2cE6+xclYXD5/nWC0InrGtYGfMQmVr5hdLy3UYQu5GO
M0JaWKuvZE06/pz4ntPKWx0wX15o12ojHQy1IgD9d/J5pe2odAZ2WIueioJAqVes
0PM3rgSlsdFanI+RNAm5OUmTNqVF9S+ctbdjJN0MpJVBBun1XtdyefhnBeNRZIRf
9wmMiHU5sFcg3wEraIQ2lZoPCvFcNw4FHt95S5wS3zNI8FJUN0zm4gLe36hh0EU=
=qaLQ
-----END PGP SIGNATURE-----
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-12-25 14:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-12-25 11:29 [PATCH] doc fix - brlock was removed in the 3.13 kernel series Nicholas Mc Guire
2014-12-25 14:42 ` Rik van Riel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox