Re: [PATCH 1/2 v3] adjtimex.2: add fields in struct timex description

["Michael Kerrisk (man-pages)" <mtk.manpages@gmail.com>]

Hello Laurent,

Sorry for the delayed follow up...

On 11/30/2014 11:14 AM, Laurent Georget wrote:
> Hello,
> 
> this is a refactored series of patches for adjtimex(2) man page. Please
> ignore all previous patches I sent for adjtimex.2.

Thanks for the clear note about disregarding previous versions. That
makes things much simpler for me.

> The first patch updates the man page with the new fields added in struct
> timex since last edition of the man page.
> 
> Thank you for your time. These are my first patches so you may have to
> bear with me being a little inexpert and clumsy for some time. I
> apologize for that.

I've applied the patch. Note one point/question below.

> diff --git a/man2/adjtimex.2 b/man2/adjtimex.2
> index eb3fda1..0b919c5 100644
> --- a/man2/adjtimex.2
> +++ b/man2/adjtimex.2
> @@ -73,6 +73,15 @@ struct timex {
>                              (read-only) */
>      struct timeval time; /* current time (read-only) */
>      long tick;           /* usecs between clock ticks */
> +    long ppsfreq;        /* pps frequency (scaled ppm) (read-only) */
> +    long jitter;         /* pps jitter (usec) (read-only) */
> +    int shift;           /* interval duration (sec) (read-only) */
> +    long stabil;         /* pps stability (scaled ppm) (read-only) */
> +    long jitcnt;         /* jitter limit exceeded (read-only) */
> +    long calcnt;         /* calibration intervals (read-only) */
> +    long errcnt;         /* calibration errors (read-only) */
> +    long stbcnt;         /* stability limit exceeded (read-only) */
> +    int tai;             /* TAI offset (s) (read-only) */
>  };

Presumably, '(s)' means seconds, right? 

I changed this to to '(sec)' for consistency with the other 
comments above.

Thanks,

Michael`


-- 
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/