From: Ian Abbott <abbotti@mev.co.uk>
To: jitendra kumar khasdev <jkhasdev@gmail.com>,
hsweeten@visionengravers.com, gregkh@linuxfoundation.org,
chase.southwood@gmail.com
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] Staging: comedi: driver : fix max 80 character coding style issue in s626.c
Date: Tue, 30 Dec 2014 22:23:20 +0000 [thread overview]
Message-ID: <54A325D8.9090902@mev.co.uk> (raw)
In-Reply-To: <1419845268-7833-1-git-send-email-jkhasdev@gmail.com>
On 29/12/14 09:27, jitendra kumar khasdev wrote:
> This is a patch to the s626.c file that fixes up a maximum 80 character limit
> warning found by the checkpatch.pl tool
>
> Signed-off-by: Jitendra Kumar Khasdev <jkhasdev@gmail.com>
> ---
> drivers/staging/comedi/drivers/s626.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/comedi/drivers/s626.c b/drivers/staging/comedi/drivers/s626.c
> index fc497dd..77f715b 100644
> --- a/drivers/staging/comedi/drivers/s626.c
> +++ b/drivers/staging/comedi/drivers/s626.c
> @@ -2534,7 +2534,8 @@ static int s626_initialize(struct comedi_device *dev)
> for (i = 0; i < 2; i++) {
> writel(S626_I2C_CLKSEL, dev->mmio + S626_P_I2CSTAT);
> s626_mc_enable(dev, S626_MC2_UPLD_IIC, S626_P_MC2);
> - ret = comedi_timeout(dev, NULL, NULL, s626_i2c_handshake_eoc, 0);
> + ret = comedi_timeout(dev, NULL, NULL, s626_i2c_handshake_eoc,
> + 0);
Technically it meets the requirements, but our comedi house style is to
indent the continuation of the statement just past the opening
bracket/parenthesis like so:
ret = comedi_timeout(dev, NULL, NULL, s626_i2c_handshake_eoc,
0);
--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=-
-=( Web: http://www.mev.co.uk/ )=-
prev parent reply other threads:[~2014-12-30 22:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-29 9:27 [PATCH 2/2] Staging: comedi: driver : fix max 80 character coding style issue in s626.c jitendra kumar khasdev
2014-12-30 22:23 ` Ian Abbott [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54A325D8.9090902@mev.co.uk \
--to=abbotti@mev.co.uk \
--cc=chase.southwood@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=hsweeten@visionengravers.com \
--cc=jkhasdev@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox