From: Jonas Lundqvist <jonas@gannon.se>
To: Jeremiah Mahler <jmmahler@gmail.com>,
airlied@linux.ie, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm: Move two seq_printf's outside of locked mutex
Date: Wed, 31 Dec 2014 09:55:19 +0100 [thread overview]
Message-ID: <54A3B9F7.4080808@gannon.se> (raw)
In-Reply-To: <20141230225211.GB31616@hudson.localdomain>
[-- Attachment #1: Type: text/plain, Size: 718 bytes --]
Hi Jeremiah,
On 12/30/2014 11:52 PM, Jeremiah Mahler wrote:
> You changed 'i' but you didn't explain in your log message why you did this.
I can change the commit message to something more generic. "Move code
outside of locked mutex" or similar.
> Does this change really improve anything? It may work the same with the
> locks moved around. But if you look at the function as a whole, the
> locks encapsulate the body of this function nicely. I like the original
> design better.
The locking was already done this way, ie after the seq_printf, in the
functions drm_clients_info() and drm_gem_name_info() in thr same file.
So this change is really more of an alignment.
Best regards
Jonas
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2014-12-31 8:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-30 21:54 [PATCH] drm: Move two seq_printf's outside of locked mutex Jonas Lundqvist
2014-12-30 22:52 ` Jeremiah Mahler
2014-12-31 8:55 ` Jonas Lundqvist [this message]
2014-12-31 15:13 ` Jeremiah Mahler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54A3B9F7.4080808@gannon.se \
--to=jonas@gannon.se \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=jmmahler@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox