Re: [PATCH V2 2/2] ARM: l2c: AM437x: Introduce support for cache filter programming

Tomasz Figa
2015-01-03T06:40:06Z

Hi Nishanth,

2015-01-03 2:43 GMT+09:00 Nishanth Menon <nm@ti.com>:
> AM437x generation of processors support programming the PL310 L2Cache
> controller's address filter start and end registers using a secure
> montior service.

typo: s/montior/monitor/

[snip]

> + base = omap4_get_l2cache_base();
> + filter_start = (reg == L310_ADDR_FILTER_START) ? val :
> + readl_relaxed(base + L310_ADDR_FILTER_START);
> + filter_end = (reg == L310_ADDR_FILTER_END) ? val :
> + readl_relaxed(base + L310_ADDR_FILTER_END);
> + omap_smc1_2(AM43X_MON_L2X0_SETFILTER_INDEX, filter_start,
> + filter_end);
> + return;

I don't have any significant comments about this patch in particular,
but just noticed that you need to do read-backs here (and the typo
thanks to the spell checker of my mailing app). Maybe you should
consider switching to the .configure() API I introduced in my series?
This would let you get rid of the hardcoded static mapping.

Best regards,
Tomasz