* [PATCH] sound: soc: soc-pcm: Remove useless varialbe 'i'
@ 2015-01-03 9:45 Chen Gang
2015-01-03 9:59 ` Takashi Iwai
0 siblings, 1 reply; 3+ messages in thread
From: Chen Gang @ 2015-01-03 9:45 UTC (permalink / raw)
To: lgirdwood, broonie, perex, tiwai, alsa-devel; +Cc: linux-kernel@vger.kernel.org
'i' is useless in soc_pcm_set_msb(), so remove it, the related warning
(with allmodconfig under s390):
CC [M] sound/soc/soc-pcm.o
sound/soc/soc-pcm.c: In function 'soc_pcm_set_msb':
sound/soc/soc-pcm.c:307:11: warning: unused variable 'i' [-Wunused-variable]
int ret, i;
^
Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
---
sound/soc/soc-pcm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/soc-pcm.c b/sound/soc/soc-pcm.c
index d6e8d6b..6b0136e 100644
--- a/sound/soc/soc-pcm.c
+++ b/sound/soc/soc-pcm.c
@@ -304,7 +304,7 @@ static bool soc_pcm_has_symmetry(struct snd_pcm_substream *substream)
static void soc_pcm_set_msb(struct snd_pcm_substream *substream, int bits)
{
struct snd_soc_pcm_runtime *rtd = substream->private_data;
- int ret, i;
+ int ret;
if (!bits)
return;
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] sound: soc: soc-pcm: Remove useless varialbe 'i'
2015-01-03 9:45 [PATCH] sound: soc: soc-pcm: Remove useless varialbe 'i' Chen Gang
@ 2015-01-03 9:59 ` Takashi Iwai
2015-01-03 10:15 ` Chen Gang S
0 siblings, 1 reply; 3+ messages in thread
From: Takashi Iwai @ 2015-01-03 9:59 UTC (permalink / raw)
To: Chen Gang
Cc: lgirdwood, broonie, perex, alsa-devel,
linux-kernel@vger.kernel.org
At Sat, 03 Jan 2015 17:45:57 +0800,
Chen Gang wrote:
>
> 'i' is useless in soc_pcm_set_msb(), so remove it, the related warning
> (with allmodconfig under s390):
>
> CC [M] sound/soc/soc-pcm.o
> sound/soc/soc-pcm.c: In function 'soc_pcm_set_msb':
> sound/soc/soc-pcm.c:307:11: warning: unused variable 'i' [-Wunused-variable]
> int ret, i;
> ^
Thanks, but this was already fixed.
Takashi
>
> Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
> ---
> sound/soc/soc-pcm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/soc/soc-pcm.c b/sound/soc/soc-pcm.c
> index d6e8d6b..6b0136e 100644
> --- a/sound/soc/soc-pcm.c
> +++ b/sound/soc/soc-pcm.c
> @@ -304,7 +304,7 @@ static bool soc_pcm_has_symmetry(struct snd_pcm_substream *substream)
> static void soc_pcm_set_msb(struct snd_pcm_substream *substream, int bits)
> {
> struct snd_soc_pcm_runtime *rtd = substream->private_data;
> - int ret, i;
> + int ret;
>
> if (!bits)
> return;
> --
> 1.7.9.5
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] sound: soc: soc-pcm: Remove useless varialbe 'i'
2015-01-03 9:59 ` Takashi Iwai
@ 2015-01-03 10:15 ` Chen Gang S
0 siblings, 0 replies; 3+ messages in thread
From: Chen Gang S @ 2015-01-03 10:15 UTC (permalink / raw)
To: Takashi Iwai
Cc: lgirdwood, broonie, perex, alsa-devel,
linux-kernel@vger.kernel.org
On 1/3/15 17:59, Takashi Iwai wrote:
> At Sat, 03 Jan 2015 17:45:57 +0800,
> Chen Gang wrote:
>>
>> 'i' is useless in soc_pcm_set_msb(), so remove it, the related warning
>> (with allmodconfig under s390):
>>
>> CC [M] sound/soc/soc-pcm.o
>> sound/soc/soc-pcm.c: In function 'soc_pcm_set_msb':
>> sound/soc/soc-pcm.c:307:11: warning: unused variable 'i' [-Wunused-variable]
>> int ret, i;
>> ^
>
> Thanks, but this was already fixed.
>
OK, thanks.
--
Chen Gang
Open, share, and attitude like air, water, and life which God blessed
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-01-03 10:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-01-03 9:45 [PATCH] sound: soc: soc-pcm: Remove useless varialbe 'i' Chen Gang
2015-01-03 9:59 ` Takashi Iwai
2015-01-03 10:15 ` Chen Gang S
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox